Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3147)

Unified Diff: cc/playback/discardable_image_map_unittest.cc

Issue 2640983002: Rename paint data structures (Closed)
Patch Set: Re-add ios changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/discardable_image_map_unittest.cc
diff --git a/cc/playback/discardable_image_map_unittest.cc b/cc/playback/discardable_image_map_unittest.cc
index e56f1581dbc2802ed5d30fba36ba8b7bccc5113c..6737023ba07b636cd20f4acdaf2451e9e97a1430 100644
--- a/cc/playback/discardable_image_map_unittest.cc
+++ b/cc/playback/discardable_image_map_unittest.cc
@@ -11,11 +11,11 @@
#include "base/memory/ref_counted.h"
#include "base/values.h"
#include "cc/base/region.h"
+#include "cc/paint/paint_canvas.h"
#include "cc/test/fake_content_layer_client.h"
#include "cc/test/fake_recording_source.h"
#include "cc/test/skia_common.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/skia/include/core/SkCanvas.h"
#include "third_party/skia/include/core/SkGraphics.h"
#include "third_party/skia/include/core/SkImageGenerator.h"
#include "third_party/skia/include/core/SkRefCnt.h"
@@ -82,7 +82,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInRectTest) {
for (int x = 0; x < 4; ++x) {
if ((x + y) & 1) {
discardable_image[y][x] = CreateDiscardableImage(gfx::Size(500, 500));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(
discardable_image[y][x], gfx::Point(x * 512 + 6, y * 512 + 6),
paint);
@@ -155,7 +155,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInRectNonZeroLayer) {
for (int x = 0; x < 4; ++x) {
if ((x + y) & 1) {
discardable_image[y][x] = CreateDiscardableImage(gfx::Size(500, 500));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(
discardable_image[y][x],
gfx::Point(1024 + x * 512 + 6, y * 512 + 6), paint);
@@ -251,7 +251,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInRectOnePixelQuery) {
for (int x = 0; x < 4; ++x) {
if ((x + y) & 1) {
discardable_image[y][x] = CreateDiscardableImage(gfx::Size(500, 500));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(
discardable_image[y][x], gfx::Point(x * 512 + 6, y * 512 + 6),
paint);
@@ -294,7 +294,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInRectMassiveImage) {
sk_sp<SkImage> discardable_image =
CreateDiscardableImage(gfx::Size(1 << 25, 1 << 25));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(discardable_image, gfx::Point(0, 0),
paint);
@@ -327,7 +327,7 @@ TEST_F(DiscardableImageMapTest, PaintDestroyedWhileImageIsDrawn) {
DiscardableImageMap::ScopedMetadataGenerator generator(&image_map,
visible_rect.size());
{
- std::unique_ptr<SkPaint> paint(new SkPaint());
+ std::unique_ptr<PaintFlags> paint(new PaintFlags());
generator.canvas()->saveLayer(gfx::RectToSkRect(visible_rect),
paint.get());
}
@@ -349,7 +349,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInRectMaxImage) {
int dimension = std::numeric_limits<int>::max();
sk_sp<SkImage> discardable_image =
CreateDiscardableImage(gfx::Size(dimension, dimension));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(discardable_image, gfx::Point(42, 42),
paint);
@@ -384,7 +384,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInRectMaxImageMaxLayer) {
sk_sp<SkImage> discardable_image =
CreateDiscardableImage(gfx::Size(dimension, dimension));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(discardable_image, gfx::Point(0, 0),
paint);
content_layer_client.add_draw_image(discardable_image, gfx::Point(10000, 0),
@@ -435,7 +435,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesRectInBounds) {
sk_sp<SkImage> long_discardable_image =
CreateDiscardableImage(gfx::Size(10000, 100));
- SkPaint paint;
+ PaintFlags paint;
content_layer_client.add_draw_image(discardable_image, gfx::Point(-10, -11),
paint);
content_layer_client.add_draw_image(discardable_image, gfx::Point(950, 951),
@@ -488,7 +488,7 @@ TEST_F(DiscardableImageMapTest, GetDiscardableImagesInShader) {
if ((x + y) & 1) {
discardable_image[y][x] = CreateDiscardableImage(gfx::Size(500, 500));
SkMatrix scale = SkMatrix::MakeScale(x * 0.5f, y * 0.5f);
- SkPaint paint;
+ PaintFlags paint;
paint.setShader(discardable_image[y][x]->makeShader(
SkShader::kClamp_TileMode, SkShader::kClamp_TileMode, &scale));
content_layer_client.add_draw_rect(

Powered by Google App Engine
This is Rietveld 408576698