Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: cc/test/fake_content_layer_client.cc

Issue 2640983002: Rename paint data structures (Closed)
Patch Set: Clean up comments, fix mac build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/fake_content_layer_client.cc
diff --git a/cc/test/fake_content_layer_client.cc b/cc/test/fake_content_layer_client.cc
index e192e3a3f09151e5a84146a05fcf043f591cbe04..8fd891f6ed4654907d45f6df9898c1823740440f 100644
--- a/cc/test/fake_content_layer_client.cc
+++ b/cc/test/fake_content_layer_client.cc
@@ -6,12 +6,12 @@
#include <stddef.h>
+#include "cc/paint/paint_canvas.h"
+#include "cc/paint/paint_recorder.h"
#include "cc/playback/clip_display_item.h"
#include "cc/playback/display_item_list_settings.h"
#include "cc/playback/drawing_display_item.h"
#include "cc/playback/transform_display_item.h"
-#include "third_party/skia/include/core/SkCanvas.h"
-#include "third_party/skia/include/core/SkPictureRecorder.h"
#include "ui/gfx/geometry/rect_conversions.h"
#include "ui/gfx/skia_util.h"
@@ -19,12 +19,12 @@ namespace cc {
FakeContentLayerClient::ImageData::ImageData(sk_sp<const SkImage> img,
const gfx::Point& point,
- const SkPaint& paint)
+ const PaintFlags& paint)
: image(std::move(img)), point(point), paint(paint) {}
FakeContentLayerClient::ImageData::ImageData(sk_sp<const SkImage> img,
const gfx::Transform& transform,
- const SkPaint& paint)
+ const PaintFlags& paint)
: image(std::move(img)), transform(transform), paint(paint) {}
FakeContentLayerClient::ImageData::ImageData(const ImageData& other) = default;
@@ -57,13 +57,14 @@ FakeContentLayerClient::PaintContentsToDisplayList(
scoped_refptr<DisplayItemList> display_list =
DisplayItemList::Create(settings);
display_list->SetRetainVisualRectsForTesting(true);
- SkPictureRecorder recorder;
+ PaintRecorder recorder;
for (RectPaintVector::const_iterator it = draw_rects_.begin();
it != draw_rects_.end(); ++it) {
const gfx::RectF& draw_rect = it->first;
- const SkPaint& paint = it->second;
- SkCanvas* canvas = recorder.beginRecording(gfx::RectFToSkRect(draw_rect));
+ const PaintFlags& paint = it->second;
+ PaintCanvas* canvas =
+ recorder.beginRecording(gfx::RectFToSkRect(draw_rect));
canvas->drawRect(gfx::RectFToSkRect(draw_rect), paint);
display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
ToEnclosingRect(draw_rect), recorder.finishRecordingAsPicture());
@@ -75,7 +76,7 @@ FakeContentLayerClient::PaintContentsToDisplayList(
display_list->CreateAndAppendPairedBeginItem<TransformDisplayItem>(
it->transform);
}
- SkCanvas* canvas =
+ PaintCanvas* canvas =
recorder.beginRecording(it->image->width(), it->image->height());
canvas->drawImage(it->image.get(), it->point.x(), it->point.y(),
&it->paint);
@@ -90,9 +91,10 @@ FakeContentLayerClient::PaintContentsToDisplayList(
gfx::Rect draw_rect = PaintableRegion();
bool red = true;
while (!draw_rect.IsEmpty()) {
- SkPaint paint;
+ PaintFlags paint;
paint.setColor(red ? SK_ColorRED : SK_ColorBLUE);
- SkCanvas* canvas = recorder.beginRecording(gfx::RectToSkRect(draw_rect));
+ PaintCanvas* canvas =
+ recorder.beginRecording(gfx::RectToSkRect(draw_rect));
canvas->drawIRect(gfx::RectToSkIRect(draw_rect), paint);
display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
draw_rect, recorder.finishRecordingAsPicture());

Powered by Google App Engine
This is Rietveld 408576698