ios/build/config.gni - Issue 2640983002: Rename paint data structures

Side by Side Diff: ios/build/config.gni

Issue 2640983002: Rename paint data structures (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # Global list of dependencies that are conceptually bad on iOS and should	5 # Global list of dependencies that are conceptually bad on iOS and should

6 # never be added (they will never be supported).	6 # never be added (they will never be supported).

7 _ios_conceptually_bad_dependencies = [	7 _ios_conceptually_bad_dependencies = [

8 "//cc/*",	8 "//cc",
	sdefresne 2017/01/26 19:51:17 I'm not sure we want to allow dependency on //cc:p I'm not sure we want to allow dependency on //cc:paint (at least as it is currently) on iOS as it brings things from skia that are not supported on iOS (canvases for example). iOS only supports a tiny subset of skia (geometry and images IIRC). If we want to allow that dependency, I think that //cc:paint should support being seriously limited on iOS (due to the incomplete skia library). enne (OOO) 2017/01/26 20:11:33 The reason I added this is because of the ui/gfx d Show quoted text On 2017/01/26 at 19:51:17, sdefresne wrote: > I'm not sure we want to allow dependency on //cc:paint (at least as it is currently) on iOS as it brings things from skia that are not supported on iOS (canvases for example). iOS only supports a tiny subset of skia (geometry and images IIRC). > > If we want to allow that dependency, I think that //cc:paint should support being seriously limited on iOS (due to the incomplete skia library). The reason I added this is because of the ui/gfx dependency on cc/paint (in the same way that it depends on skia). https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode... //ios/web:ios_web_unittests_arch_executable_sources has an assert_no_deps entry: //cc/* which fails for the dependency path: //ios/web:ios_web_unittests_arch_executable_sources -> //ios/web:run_all_unittests -> //ios/web:test_support -> //ios/web:web -> //ios/web:web_arc -> //components/url_formatter:url_formatter -> //ui/gfx:gfx -> //cc/paint:paint Is there some way to only include this for tests? Or something else that would satisfy your concerns?
	9 "//cc:surfaces",

9 "//content/*",	10 "//content/*",

10 "//dbus/*",	11 "//dbus/*",

11 "//jingle:jingle",	12 "//jingle:jingle",

12 "//media/*",	13 "//media/*",

13 "//third_party/ffmpeg/*",	14 "//third_party/ffmpeg/*",

14 "//third_party/hunspell_dictionaries/*",	15 "//third_party/hunspell_dictionaries/*",

15 "//third_party/webgl/*",	16 "//third_party/webgl/*",

16 "//third_party/WebKit/*",	17 "//third_party/WebKit/*",

17 "//third_party/webrtc:webrtc",	18 "//third_party/webrtc:webrtc",

18 ]	19 ]

19	20

20 # Global list of conceptually fine dependencies but currently unsupported	21 # Global list of conceptually fine dependencies but currently unsupported

21 # on iOS. Exclusions will be removed when the dependencies are fixed.	22 # on iOS. Exclusions will be removed when the dependencies are fixed.

22 _ios_transient_bad_dependencies = []	23 _ios_transient_bad_dependencies = []

23	24

24 ios_assert_no_deps =	25 ios_assert_no_deps =

25 _ios_conceptually_bad_dependencies + _ios_transient_bad_dependencies	26 _ios_conceptually_bad_dependencies + _ios_transient_bad_dependencies

OLD	NEW

« no previous file with comments | « content/renderer/sad_plugin.cc ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »