Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: cc/playback/drawing_display_item.cc

Issue 2640983002: Rename paint data structures (Closed)
Patch Set: Clean up comments, fix mac build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/playback/drawing_display_item.h" 5 #include "cc/playback/drawing_display_item.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "base/trace_event/trace_event.h" 12 #include "base/trace_event/trace_event.h"
13 #include "base/trace_event/trace_event_argument.h" 13 #include "base/trace_event/trace_event_argument.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "cc/blimp/client_picture_cache.h" 15 #include "cc/blimp/client_picture_cache.h"
16 #include "cc/blimp/image_serialization_processor.h" 16 #include "cc/blimp/image_serialization_processor.h"
17 #include "cc/debug/picture_debug_util.h" 17 #include "cc/debug/picture_debug_util.h"
18 #include "cc/proto/display_item.pb.h" 18 #include "cc/proto/display_item.pb.h"
19 #include "third_party/skia/include/core/SkCanvas.h"
20 #include "third_party/skia/include/core/SkData.h" 19 #include "third_party/skia/include/core/SkData.h"
21 #include "third_party/skia/include/core/SkMatrix.h" 20 #include "third_party/skia/include/core/SkMatrix.h"
22 #include "third_party/skia/include/core/SkPicture.h"
23 #include "third_party/skia/include/core/SkStream.h" 21 #include "third_party/skia/include/core/SkStream.h"
24 #include "third_party/skia/include/utils/SkPictureUtils.h"
25 #include "ui/gfx/skia_util.h" 22 #include "ui/gfx/skia_util.h"
26 23
27 namespace cc { 24 namespace cc {
28 25
29 DrawingDisplayItem::DrawingDisplayItem() : DisplayItem(DRAWING) {} 26 DrawingDisplayItem::DrawingDisplayItem() : DisplayItem(DRAWING) {}
30 27
31 DrawingDisplayItem::DrawingDisplayItem(sk_sp<const SkPicture> picture) 28 DrawingDisplayItem::DrawingDisplayItem(sk_sp<const PaintRecord> picture)
32 : DisplayItem(DRAWING) { 29 : DisplayItem(DRAWING) {
33 SetNew(std::move(picture)); 30 SetNew(std::move(picture));
34 } 31 }
35 32
36 DrawingDisplayItem::DrawingDisplayItem( 33 DrawingDisplayItem::DrawingDisplayItem(
37 const proto::DisplayItem& proto, 34 const proto::DisplayItem& proto,
38 ClientPictureCache* client_picture_cache, 35 ClientPictureCache* client_picture_cache,
39 std::vector<uint32_t>* used_engine_picture_ids) 36 std::vector<uint32_t>* used_engine_picture_ids)
40 : DisplayItem(DRAWING) { 37 : DisplayItem(DRAWING) {
41 DCHECK_EQ(proto::DisplayItem::Type_Drawing, proto.type()); 38 DCHECK_EQ(proto::DisplayItem::Type_Drawing, proto.type());
42 DCHECK(client_picture_cache); 39 DCHECK(client_picture_cache);
43 40
44 const proto::DrawingDisplayItem& details = proto.drawing_item(); 41 const proto::DrawingDisplayItem& details = proto.drawing_item();
45 DCHECK(details.has_id()); 42 DCHECK(details.has_id());
46 const proto::SkPictureID& sk_picture_id = details.id(); 43 const proto::SkPictureID& sk_picture_id = details.id();
47 DCHECK(sk_picture_id.has_unique_id()); 44 DCHECK(sk_picture_id.has_unique_id());
48 45
49 uint32_t unique_id = sk_picture_id.unique_id(); 46 uint32_t unique_id = sk_picture_id.unique_id();
50 sk_sp<const SkPicture> picture = client_picture_cache->GetPicture(unique_id); 47 sk_sp<const PaintRecord> picture =
48 client_picture_cache->GetPicture(unique_id);
51 DCHECK(picture); 49 DCHECK(picture);
52 50
53 used_engine_picture_ids->push_back(unique_id); 51 used_engine_picture_ids->push_back(unique_id);
54 SetNew(std::move(picture)); 52 SetNew(std::move(picture));
55 } 53 }
56 54
57 DrawingDisplayItem::DrawingDisplayItem(const DrawingDisplayItem& item) 55 DrawingDisplayItem::DrawingDisplayItem(const DrawingDisplayItem& item)
58 : DisplayItem(DRAWING) { 56 : DisplayItem(DRAWING) {
59 item.CloneTo(this); 57 item.CloneTo(this);
60 } 58 }
61 59
62 DrawingDisplayItem::~DrawingDisplayItem() { 60 DrawingDisplayItem::~DrawingDisplayItem() {
63 } 61 }
64 62
65 void DrawingDisplayItem::SetNew(sk_sp<const SkPicture> picture) { 63 void DrawingDisplayItem::SetNew(sk_sp<const PaintRecord> picture) {
66 picture_ = std::move(picture); 64 picture_ = std::move(picture);
67 } 65 }
68 66
69 void DrawingDisplayItem::ToProtobuf(proto::DisplayItem* proto) const { 67 void DrawingDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
70 TRACE_EVENT0("cc.remote", "DrawingDisplayItem::ToProtobuf"); 68 TRACE_EVENT0("cc.remote", "DrawingDisplayItem::ToProtobuf");
71 proto->set_type(proto::DisplayItem::Type_Drawing); 69 proto->set_type(proto::DisplayItem::Type_Drawing);
72 70
73 if (!picture_) 71 if (!picture_)
74 return; 72 return;
75 73
76 proto->mutable_drawing_item()->mutable_id()->set_unique_id( 74 proto->mutable_drawing_item()->mutable_id()->set_unique_id(
77 picture_->uniqueID()); 75 picture_->uniqueID());
78 } 76 }
79 77
80 sk_sp<const SkPicture> DrawingDisplayItem::GetPicture() const { 78 sk_sp<const PaintRecord> DrawingDisplayItem::GetPicture() const {
81 return picture_; 79 return picture_;
82 } 80 }
83 81
84 DISABLE_CFI_PERF 82 DISABLE_CFI_PERF
85 void DrawingDisplayItem::Raster(SkCanvas* canvas, 83 void DrawingDisplayItem::Raster(PaintCanvas* canvas,
86 SkPicture::AbortCallback* callback) const { 84 PaintRecord::AbortCallback* callback) const {
87 if (canvas->quickReject(picture_->cullRect())) 85 if (canvas->quickReject(picture_->cullRect()))
88 return; 86 return;
89 87
90 // SkPicture always does a wrapping save/restore on the canvas, so it is not 88 // PaintRecord always does a wrapping save/restore on the canvas, so it is not
91 // necessary here. 89 // necessary here.
92 if (callback) 90 if (callback)
93 picture_->playback(canvas, callback); 91 picture_->playback(canvas, callback);
94 else 92 else
95 canvas->drawPicture(picture_.get()); 93 canvas->drawPicture(picture_.get());
96 } 94 }
97 95
98 void DrawingDisplayItem::AsValueInto( 96 void DrawingDisplayItem::AsValueInto(
99 const gfx::Rect& visual_rect, 97 const gfx::Rect& visual_rect,
100 base::trace_event::TracedValue* array) const { 98 base::trace_event::TracedValue* array) const {
101 array->BeginDictionary(); 99 array->BeginDictionary();
102 array->SetString("name", "DrawingDisplayItem"); 100 array->SetString("name", "DrawingDisplayItem");
103 101
104 array->BeginArray("visualRect"); 102 array->BeginArray("visualRect");
105 array->AppendInteger(visual_rect.x()); 103 array->AppendInteger(visual_rect.x());
106 array->AppendInteger(visual_rect.y()); 104 array->AppendInteger(visual_rect.y());
107 array->AppendInteger(visual_rect.width()); 105 array->AppendInteger(visual_rect.width());
108 array->AppendInteger(visual_rect.height()); 106 array->AppendInteger(visual_rect.height());
109 array->EndArray(); 107 array->EndArray();
110 108
111 array->BeginArray("cullRect"); 109 array->BeginArray("cullRect");
112 array->AppendInteger(picture_->cullRect().x()); 110 array->AppendInteger(picture_->cullRect().x());
113 array->AppendInteger(picture_->cullRect().y()); 111 array->AppendInteger(picture_->cullRect().y());
114 array->AppendInteger(picture_->cullRect().width()); 112 array->AppendInteger(picture_->cullRect().width());
115 array->AppendInteger(picture_->cullRect().height()); 113 array->AppendInteger(picture_->cullRect().height());
116 array->EndArray(); 114 array->EndArray();
117 115
118 std::string b64_picture; 116 std::string b64_picture;
119 PictureDebugUtil::SerializeAsBase64(picture_.get(), &b64_picture); 117 PictureDebugUtil::SerializeAsBase64(ToSkPicture(picture_.get()),
118 &b64_picture);
120 array->SetString("skp64", b64_picture); 119 array->SetString("skp64", b64_picture);
121 array->EndDictionary(); 120 array->EndDictionary();
122 } 121 }
123 122
124 void DrawingDisplayItem::CloneTo(DrawingDisplayItem* item) const { 123 void DrawingDisplayItem::CloneTo(DrawingDisplayItem* item) const {
125 item->SetNew(picture_); 124 item->SetNew(picture_);
126 } 125 }
127 126
128 size_t DrawingDisplayItem::ExternalMemoryUsage() const { 127 size_t DrawingDisplayItem::ExternalMemoryUsage() const {
129 return SkPictureUtils::ApproximateBytesUsed(picture_.get()); 128 return SkPictureUtils::ApproximateBytesUsed(picture_.get());
130 } 129 }
131 130
132 DISABLE_CFI_PERF 131 DISABLE_CFI_PERF
133 int DrawingDisplayItem::ApproximateOpCount() const { 132 int DrawingDisplayItem::ApproximateOpCount() const {
134 return picture_->approximateOpCount(); 133 return picture_->approximateOpCount();
135 } 134 }
136 135
137 } // namespace cc 136 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698