Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

Issue 2640963007: [wrapper-tracing] Remove flag and object grouping entry points (Closed)
Patch Set: Fix merge artifact Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
index d0262646afcd8e928c932d033f218c1f34efe04d..2d4af91ec14f4aa55201d5c80150420a992b2ee1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
@@ -94,16 +94,13 @@ inline void V8DOMWrapper::setNativeInfo(v8::Isolate* isolate,
const_cast<WrapperTypeInfo*>(wrapperTypeInfo)};
wrapper->SetAlignedPointerInInternalFields(WTF_ARRAY_LENGTH(indices), indices,
values);
- if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- auto perIsolateData = V8PerIsolateData::from(isolate);
- // We notify ScriptWrappableVisitor about the new wrapper association,
- // so the visitor can make sure to trace the association (in case it is
- // currently tracing). Because of some optimizations, V8 will not
- // necessarily detect wrappers created during its incremental marking.
- perIsolateData->scriptWrappableVisitor()->RegisterV8Reference(
- std::make_pair(const_cast<WrapperTypeInfo*>(wrapperTypeInfo),
- scriptWrappable));
- }
+ auto perIsolateData = V8PerIsolateData::from(isolate);
+ // We notify ScriptWrappableVisitor about the new wrapper association,
+ // so the visitor can make sure to trace the association (in case it is
+ // currently tracing). Because of some optimizations, V8 will not
+ // necessarily detect wrappers created during its incremental marking.
+ perIsolateData->scriptWrappableVisitor()->RegisterV8Reference(std::make_pair(
+ const_cast<WrapperTypeInfo*>(wrapperTypeInfo), scriptWrappable));
}
inline void V8DOMWrapper::clearNativeInfo(v8::Isolate* isolate,

Powered by Google App Engine
This is Rietveld 408576698