Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2640963007: [wrapper-tracing] Remove flag and object grouping entry points (Closed)
Patch Set: Fix merge artifact Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
index b877724d34d4c04e286a2b8bab2d6adba781a1e8..bd78c6c66c9bd38bbc447af9c93c812c5793e298 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
@@ -37,9 +37,6 @@ static bool DequeContains(const WTF::Deque<WrapperMarkingData>& deque,
TEST(ScriptWrappableVisitorTest, ScriptWrappableVisitorTracesWrappers) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
ScriptWrappableVisitor* visitor =
V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();
visitor->TracePrologue();
@@ -74,9 +71,6 @@ TEST(ScriptWrappableVisitorTest, ScriptWrappableVisitorTracesWrappers) {
TEST(ScriptWrappableVisitorTest, OilpanCollectObjectsNotReachableFromV8) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
v8::Isolate* isolate = scope.isolate();
{
@@ -97,9 +91,6 @@ TEST(ScriptWrappableVisitorTest, OilpanCollectObjectsNotReachableFromV8) {
TEST(ScriptWrappableVisitorTest, OilpanDoesntCollectObjectsReachableFromV8) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
v8::Isolate* isolate = scope.isolate();
v8::HandleScope handleScope(isolate);
DeathAwareScriptWrappable* object = DeathAwareScriptWrappable::create();
@@ -117,9 +108,6 @@ TEST(ScriptWrappableVisitorTest, OilpanDoesntCollectObjectsReachableFromV8) {
TEST(ScriptWrappableVisitorTest, V8ReportsLiveObjectsDuringScavenger) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
v8::Isolate* isolate = scope.isolate();
v8::HandleScope handleScope(isolate);
DeathAwareScriptWrappable* object = DeathAwareScriptWrappable::create();
@@ -143,9 +131,6 @@ TEST(ScriptWrappableVisitorTest, V8ReportsLiveObjectsDuringScavenger) {
TEST(ScriptWrappableVisitorTest, V8ReportsLiveObjectsDuringFullGc) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
v8::Isolate* isolate = scope.isolate();
v8::HandleScope handleScope(isolate);
DeathAwareScriptWrappable* object = DeathAwareScriptWrappable::create();
@@ -162,9 +147,6 @@ TEST(ScriptWrappableVisitorTest, V8ReportsLiveObjectsDuringFullGc) {
TEST(ScriptWrappableVisitorTest, OilpanClearsHeadersWhenObjectDied) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
DeathAwareScriptWrappable* object = DeathAwareScriptWrappable::create();
ScriptWrappableVisitor* visitor =
@@ -181,9 +163,6 @@ TEST(ScriptWrappableVisitorTest, OilpanClearsHeadersWhenObjectDied) {
TEST(ScriptWrappableVisitorTest, OilpanClearsMarkingDequeWhenObjectDied) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
DeathAwareScriptWrappable* object = DeathAwareScriptWrappable::create();
ScriptWrappableVisitor* visitor =
@@ -203,9 +182,6 @@ TEST(ScriptWrappableVisitorTest, OilpanClearsMarkingDequeWhenObjectDied) {
TEST(ScriptWrappableVisitorTest, NonMarkedObjectDoesNothingOnWriteBarrierHit) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
ScriptWrappableVisitor* visitor =
V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();
@@ -225,9 +201,6 @@ TEST(ScriptWrappableVisitorTest, NonMarkedObjectDoesNothingOnWriteBarrierHit) {
TEST(ScriptWrappableVisitorTest,
MarkedObjectDoesNothingOnWriteBarrierHitWhenDependencyIsMarkedToo) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
ScriptWrappableVisitor* visitor =
V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();
@@ -258,9 +231,6 @@ TEST(ScriptWrappableVisitorTest,
TEST(ScriptWrappableVisitorTest,
MarkedObjectMarksDependencyOnWriteBarrierHitWhenNotMarked) {
V8TestingScope scope;
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
- return;
- }
ScriptWrappableVisitor* visitor =
V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();
@@ -342,8 +312,6 @@ void swapInNewVisitor(v8::Isolate* isolate,
} // namespace
TEST(ScriptWrappableVisitorTest, NoWriteBarrierOnUnmarkedContainer) {
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled())
- return;
V8TestingScope scope;
auto rawVisitor = new InterceptingScriptWrappableVisitor(scope.isolate());
swapInNewVisitor(scope.isolate(), rawVisitor);
@@ -364,8 +332,6 @@ TEST(ScriptWrappableVisitorTest, NoWriteBarrierOnUnmarkedContainer) {
}
TEST(ScriptWrappableVisitorTest, WriteBarrierTriggersOnMarkedContainer) {
- if (!RuntimeEnabledFeatures::traceWrappablesEnabled())
- return;
V8TestingScope scope;
auto rawVisitor = new InterceptingScriptWrappableVisitor(scope.isolate());
swapInNewVisitor(scope.isolate(), rawVisitor);

Powered by Google App Engine
This is Rietveld 408576698