Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2640923005: GN: Add back -fPIC for a few things (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : GN: Add back -fPIC for a few things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 11 months ago (2017-01-20 22:25:23 UTC) #2
zra
TBR
3 years, 11 months ago (2017-01-20 22:37:39 UTC) #3
zra
Committed patchset #2 (id:20001) manually as 5580693fa8ec3b1780af35aed378f0968371945c (presubmit successful).
3 years, 11 months ago (2017-01-20 22:37:55 UTC) #5
rmacnak
3 years, 11 months ago (2017-01-20 22:55:35 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698