Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Side by Side Diff: components/offline_pages/core/client_policy_controller.cc

Issue 2640923003: Remove popup overlay from MHTML when requested (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/client_policy_controller.h" 5 #include "components/offline_pages/core/client_policy_controller.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 17 matching lines...) Expand all
28 .SetExpirePeriod(base::TimeDelta::FromDays(2)) 28 .SetExpirePeriod(base::TimeDelta::FromDays(2))
29 .SetIsSupportedByRecentTabs(true) 29 .SetIsSupportedByRecentTabs(true)
30 .SetIsOnlyShownInOriginalTab(true) 30 .SetIsOnlyShownInOriginalTab(true)
31 .Build())); 31 .Build()));
32 policies_.insert(std::make_pair( 32 policies_.insert(std::make_pair(
33 kAsyncNamespace, 33 kAsyncNamespace,
34 OfflinePageClientPolicyBuilder(kAsyncNamespace, LifetimeType::PERSISTENT, 34 OfflinePageClientPolicyBuilder(kAsyncNamespace, LifetimeType::PERSISTENT,
35 kUnlimitedPages, kUnlimitedPages) 35 kUnlimitedPages, kUnlimitedPages)
36 .SetIsSupportedByDownload(true) 36 .SetIsSupportedByDownload(true)
37 .SetIsRemovedOnCacheReset(false) 37 .SetIsRemovedOnCacheReset(false)
38 .SetRemovePopupOverlay(true)
38 .Build())); 39 .Build()));
39 policies_.insert(std::make_pair( 40 policies_.insert(std::make_pair(
40 kCCTNamespace, 41 kCCTNamespace,
41 MakePolicy(kCCTNamespace, LifetimeType::TEMPORARY, 42 MakePolicy(kCCTNamespace, LifetimeType::TEMPORARY,
42 base::TimeDelta::FromDays(2), kUnlimitedPages, 1))); 43 base::TimeDelta::FromDays(2), kUnlimitedPages, 1)));
43 policies_.insert(std::make_pair( 44 policies_.insert(std::make_pair(
44 kDownloadNamespace, OfflinePageClientPolicyBuilder( 45 kDownloadNamespace, OfflinePageClientPolicyBuilder(
45 kDownloadNamespace, LifetimeType::PERSISTENT, 46 kDownloadNamespace, LifetimeType::PERSISTENT,
46 kUnlimitedPages, kUnlimitedPages) 47 kUnlimitedPages, kUnlimitedPages)
47 .SetIsRemovedOnCacheReset(false) 48 .SetIsRemovedOnCacheReset(false)
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 148
148 show_in_original_tab_cache_ = base::MakeUnique<std::vector<std::string>>(); 149 show_in_original_tab_cache_ = base::MakeUnique<std::vector<std::string>>();
149 for (const auto& policy_item : policies_) { 150 for (const auto& policy_item : policies_) {
150 if (policy_item.second.feature_policy.only_shown_in_original_tab) 151 if (policy_item.second.feature_policy.only_shown_in_original_tab)
151 show_in_original_tab_cache_->emplace_back(policy_item.first); 152 show_in_original_tab_cache_->emplace_back(policy_item.first);
152 } 153 }
153 154
154 return *show_in_original_tab_cache_; 155 return *show_in_original_tab_cache_;
155 } 156 }
156 157
158 bool ClientPolicyController::ShouldRemovePopupOverlay(
159 const std::string& name_space) const {
160 return GetPolicy(name_space).feature_policy.remove_popup_overlay;
161 }
162
157 void ClientPolicyController::AddPolicyForTest( 163 void ClientPolicyController::AddPolicyForTest(
158 const std::string& name_space, 164 const std::string& name_space,
159 const OfflinePageClientPolicyBuilder& builder) { 165 const OfflinePageClientPolicyBuilder& builder) {
160 policies_.insert(std::make_pair(name_space, builder.Build())); 166 policies_.insert(std::make_pair(name_space, builder.Build()));
161 } 167 }
162 168
163 } // namespace offline_pages 169 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698