Issue 2640903005: Use loading task queue in ScriptInjectionManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2640903005: Use loading task queue in ScriptInjectionManager

Created:
3 years, 11 months ago by altimin

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use loading task queue in ScriptInjectionManager As a part of effort to post tasks to correct scheduler task queues instead of default one, use frame-specific loading task runner in ScriptInjectionManager. BUG=676805

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -2 lines)			Patch
M	content/public/renderer/render_frame.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/renderer/render_frame_impl.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	extensions/renderer/script_injection_manager.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

altimin

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

3 years, 11 months ago (2017-01-19 13:25:25 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640903005/1

3 years, 11 months ago (2017-01-19 13:25:46 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-19 14:10:58 UTC) #3

commit-bot: I haz the power

3 years, 11 months ago (2017-01-19 14:10:58 UTC) #4

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages