Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2640853005: Make Analyzer, VM and dart2js accept URI strings as part-of library identifier. (Closed)
Patch Set: Add tests, enable flag by default in analyzer. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 05528d7f03960538894c15a1bc7dd2c17eab31bf..b01c85fad665d961149c147be013a93356639a7b 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -1618,7 +1618,8 @@ class BuildLibraryElementTask extends SourceBasedAnalysisTask {
}
}
}
- if (hasPartDirective && libraryNameNode == null) {
+ if (hasPartDirective && libraryNameNode == null &&
+ !context.analysisOptions.enableUriInPartOf) {
Brian Wilkerson 2017/01/25 17:05:14 Will we issue a warning if a part file contains a
Lasse Reichstein Nielsen 2017/01/26 10:39:13 It's still a warning, and I don't think there is a
AnalysisError error;
if (partsLibraryName != _UNKNOWN_LIBRARY_NAME &&
partsLibraryName != null) {

Powered by Google App Engine
This is Rietveld 408576698