Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 2640853005: Make Analyzer, VM and dart2js accept URI strings as part-of library identifier. (Closed)
Patch Set: Status fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/messages.dart ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 5c3615125672fe000ff13ef9cce687c9fa300c3b..5bfd56f46cc1c1ec9bfc4358a11b39ea728998ce 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -767,6 +767,20 @@ class CompilationUnitElementX extends ElementX
}
partTag = tag;
LibraryName libraryTag = library.libraryTag;
+
+ Expression libraryReference = tag.name;
+ if (libraryReference is LiteralString) {
+ // Name is a URI. Resolve and compare to library's URI.
+ String content = libraryReference.dartString.slowToString();
+ Uri uri = this.script.readableUri.resolve(content);
+ Uri expectedUri = library.canonicalUri;
+ if (uri != expectedUri) {
+ // Consider finding a relative URI reference for the error message.
+ reporter.reportWarningMessage(tag.name,
+ MessageKind.LIBRARY_URI_MISMATCH, {'libraryUri': expectedUri});
+ }
+ return;
+ }
String actualName = tag.name.toString();
if (libraryTag != null) {
String expectedName = libraryTag.name.toString();
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/messages.dart ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698