Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 2640853005: Make Analyzer, VM and dart2js accept URI strings as part-of library identifier. (Closed)
Patch Set: Status fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.test.src.task.dart_test; 5 library analyzer.test.src.task.dart_test;
6 6
7 import 'package:analyzer/dart/ast/ast.dart'; 7 import 'package:analyzer/dart/ast/ast.dart';
8 import 'package:analyzer/dart/ast/standard_resolution_map.dart'; 8 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
9 import 'package:analyzer/dart/ast/token.dart'; 9 import 'package:analyzer/dart/ast/token.dart';
10 import 'package:analyzer/dart/ast/visitor.dart'; 10 import 'package:analyzer/dart/ast/visitor.dart';
(...skipping 852 matching lines...) Expand 10 before | Expand all | Expand 10 after
863 part 'partA.dart'; 863 part 'partA.dart';
864 part 'partB.dart'; 864 part 'partB.dart';
865 ''', 865 ''',
866 '/partA.dart': ''' 866 '/partA.dart': '''
867 part of my_lib; 867 part of my_lib;
868 ''', 868 ''',
869 '/partB.dart': ''' 869 '/partB.dart': '''
870 part of my_lib; 870 part of my_lib;
871 ''' 871 '''
872 }); 872 });
873 _assertErrorsWithCodes( 873 if (context.analysisOptions.enableUriInPartOf) {
874 [ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART]); 874 // TODO(28522)
875 // Should report that names are wrong.
876 } else {
877 _assertErrorsWithCodes(
878 [ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART]);
879 AnalysisError error = errorListener.errors[0];
880 }
881 }
882
883 test_perform_error_missingLibraryDirectiveWithPart_noCommon() {
884 _performBuildTask({
885 '/lib.dart': '''
886 part 'partA.dart';
887 part 'partB.dart';
888 ''',
889 '/partA.dart': '''
890 part of libA;
891 ''',
892 '/partB.dart': '''
893 part of libB;
894 '''
895 });
896 if (context.analysisOptions.enableUriInPartOf) {
897 // TODO(28522)
898 // Should report that names are wrong.
899 } else {
900 _assertErrorsWithCodes(
901 [ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART]);
902 AnalysisError error = errorListener.errors[0];
903 }
875 } 904 }
876 905
877 test_perform_error_partDoesNotExist() { 906 test_perform_error_partDoesNotExist() {
878 _performBuildTask({ 907 _performBuildTask({
879 '/lib.dart': ''' 908 '/lib.dart': '''
880 library lib; 909 library lib;
881 part 'part.dart'; 910 part 'part.dart';
882 ''' 911 '''
883 }); 912 });
884 // we already report URI_DOES_NOT_EXIST, no need to report other errors 913 // we already report URI_DOES_NOT_EXIST, no need to report other errors
(...skipping 4823 matching lines...) Expand 10 before | Expand all | Expand 10 after
5708 /** 5737 /**
5709 * Fill [errorListener] with [result] errors in the current [task]. 5738 * Fill [errorListener] with [result] errors in the current [task].
5710 */ 5739 */
5711 void _fillErrorListener(ResultDescriptor<List<AnalysisError>> result) { 5740 void _fillErrorListener(ResultDescriptor<List<AnalysisError>> result) {
5712 List<AnalysisError> errors = task.outputs[result] as List<AnalysisError>; 5741 List<AnalysisError> errors = task.outputs[result] as List<AnalysisError>;
5713 expect(errors, isNotNull, reason: result.name); 5742 expect(errors, isNotNull, reason: result.name);
5714 errorListener = new GatheringErrorListener(); 5743 errorListener = new GatheringErrorListener();
5715 errorListener.addAll(errors); 5744 errorListener.addAll(errors);
5716 } 5745 }
5717 } 5746 }
OLDNEW
« no previous file with comments | « pkg/analyzer/test/src/dart/analysis/driver_test.dart ('k') | pkg/compiler/lib/src/diagnostics/messages.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698