Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Side by Side Diff: pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

Issue 2640853005: Make Analyzer, VM and dart2js accept URI strings as part-of library identifier. (Closed)
Patch Set: Status fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « CHANGELOG.md ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analyzer/context/declared_variables.dart'; 5 import 'package:analyzer/context/declared_variables.dart';
6 import 'package:analyzer/dart/ast/ast.dart'; 6 import 'package:analyzer/dart/ast/ast.dart';
7 import 'package:analyzer/dart/ast/visitor.dart'; 7 import 'package:analyzer/dart/ast/visitor.dart';
8 import 'package:analyzer/dart/element/element.dart'; 8 import 'package:analyzer/dart/element/element.dart';
9 import 'package:analyzer/error/error.dart'; 9 import 'package:analyzer/error/error.dart';
10 import 'package:analyzer/error/listener.dart'; 10 import 'package:analyzer/error/listener.dart';
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 partUri, 467 partUri,
468 [_library.uriStr, source.uri]); 468 [_library.uriStr, source.uri]);
469 } 469 }
470 } 470 }
471 } 471 }
472 } 472 }
473 } 473 }
474 } 474 }
475 } 475 }
476 476
477 if (hasPartDirective && libraryNameNode == null) { 477 if (hasPartDirective && libraryNameNode == null &&
478 !_context.analysisOptions.enableUriInPartOf) {
478 libraryErrorReporter.reportErrorForOffset( 479 libraryErrorReporter.reportErrorForOffset(
479 ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART, 0, 0); 480 ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART, 0, 0);
480 } 481 }
481 482
482 // 483 //
483 // Resolve the relevant directives to the library element. 484 // Resolve the relevant directives to the library element.
484 // 485 //
485 for (Directive directive in directivesToResolve) { 486 for (Directive directive in directivesToResolve) {
486 directive.element = _libraryElement; 487 directive.element = _libraryElement;
487 } 488 }
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 } 760 }
760 761
761 /** 762 /**
762 * Either the name or the source associated with a part-of directive. 763 * Either the name or the source associated with a part-of directive.
763 */ 764 */
764 class _NameOrSource { 765 class _NameOrSource {
765 final String name; 766 final String name;
766 final Source source; 767 final Source source;
767 _NameOrSource(this.name, this.source); 768 _NameOrSource(this.name, this.source);
768 } 769 }
OLDNEW
« no previous file with comments | « CHANGELOG.md ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698