Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2640833002: Mark 2 precompilation tests as passing after fixing [StringInterpolateInstr::Canonicalize] (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark 2 precompilation tests as passing after fixing [StringInterpolateInstr::Canonicalize] Committed: https://github.com/dart-lang/sdk/commit/887b4775a147fd458962b2a56c9a4e9f2495908a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kustermann
3 years, 11 months ago (2017-01-18 13:58:37 UTC) #2
kustermann
Committed patchset #1 (id:1) manually as 887b4775a147fd458962b2a56c9a4e9f2495908a (presubmit successful).
3 years, 11 months ago (2017-01-18 14:00:05 UTC) #4
Vyacheslav Egorov (Google)
lgtm
3 years, 11 months ago (2017-01-18 14:01:07 UTC) #5
jensj
3 years, 11 months ago (2017-01-18 14:10:36 UTC) #7
Message was sent while issue was closed.
Didn't the change also fix write_A01_t02?
(https://uberchromegw.corp.google.com/i/client.dart/builders/vm-kernel-precomp...)

Powered by Google App Engine
This is Rietveld 408576698