Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h

Issue 2640823004: Allow origin trials to be enabled by script (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h
diff --git a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h
index 4e86349c978720292b3d5c36b3abb35cdda00625..5d72cf746dbafd35ff583662f0d5fe38fa394f9b 100644
--- a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h
+++ b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h
@@ -26,12 +26,13 @@
#ifndef WebCoreTestSupport_h
#define WebCoreTestSupport_h
+#include "wtf/text/WTFString.h"
#include <v8.h>
namespace blink {
class ScriptState;
struct WrapperTypeInfo;
-}
+} // namespace blink
namespace WebCoreTestSupport {
@@ -42,7 +43,9 @@ void installConditionalFeaturesForTests(
const blink::ScriptState*,
v8::Local<v8::Object> prototypeObject,
v8::Local<v8::Function> interfaceObject);
-
-} // namespace blink
+void installPendingConditionalFeatureForTests(const String&,
iclelland 2017/01/26 20:14:12 nit: I think we should name the variable here, Str
chasej 2017/01/27 17:22:36 I realized the function declaration isn't needed a
+ const blink::ScriptState*);
+void registerInstallConditionalFeaturesForTests();
+} // namespace WebCoreTestSupport
iclelland 2017/01/26 20:14:12 nit: Blank line before
chasej 2017/01/27 17:22:36 Done.
#endif

Powered by Google App Engine
This is Rietveld 408576698