Allow origin trials to be enabled by script

third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/modules/v8/ConditionalFeaturesForModules.h"
 
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8DedicatedWorkerGlobalScope.h"
 #include "bindings/core/v8/V8Navigator.h"
 #include "bindings/core/v8/V8SharedWorkerGlobalScope.h"
@@ skipping 11 matching lines @@
 #include "bindings/modules/v8/V8WindowPartial.h"
 #include "bindings/modules/v8/V8WorkerNavigatorPartial.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/origin_trials/OriginTrials.h"
 
 namespace blink {
 
 namespace {
 InstallConditionalFeaturesFunction
     s_originalInstallConditionalFeaturesFunction = nullptr;
+InstallPendingConditionalFeatureFunction
+    s_originalInstallPendingConditionalFeatureFunction = nullptr;
 }
 
 void installConditionalFeaturesForModules(
     const WrapperTypeInfo* wrapperTypeInfo,
     const ScriptState* scriptState,
     v8::Local<v8::Object> prototypeObject,
     v8::Local<v8::Function> interfaceObject) {
   // TODO(iclelland): Generate all of this logic at compile-time, based on the
   // configuration of origin trial enabled attibutes and interfaces in IDL
   // files. (crbug.com/615060)
@@ skipping 91 matching lines @@
     }
   } else if (wrapperTypeInfo == &V8GamepadButton::wrapperTypeInfo) {
     if (OriginTrials::gamepadExtensionsEnabled(executionContext)) {
       V8GamepadButton::installGamepadExtensions(
           isolate, world, v8::Local<v8::Object>(), prototypeObject,
           interfaceObject);
     }
   }
 }
 
+void installPendingConditionalFeatureForModules(
+    const String& feature,
+    const ScriptState* scriptState) {
+  // TODO(iclelland): Generate all of this logic at compile-time, based on the
+  // configuration of origin trial enabled attributes and interfaces in IDL
+  // files. (crbug.com/615060)
+  (*s_originalInstallPendingConditionalFeatureFunction)(feature, scriptState);
+  v8::Local<v8::Object> prototypeObject;
+  v8::Local<v8::Function> interfaceObject;
+  v8::Isolate* isolate = scriptState->isolate();
+  const DOMWrapperWorld& world = scriptState->world();
+  if (feature == "ForeignFetch") {
+    if (getExistingConstructorAndPrototypeForType(
+            &V8InstallEvent::wrapperTypeInfo, scriptState, &prototypeObject,
+            &interfaceObject)) {
+      V8InstallEvent::installForeignFetch(isolate, world,
+                                          v8::Local<v8::Object>(),
+                                          prototypeObject, interfaceObject);
+    }
+    return;
+  }
+  if (feature == "ImageCapture") {
+    v8::Local<v8::Object> instanceObject = scriptState->context()->Global();
+    V8WindowPartial::installImageCapture(isolate, world, instanceObject,
+                                         v8::Local<v8::Object>(),
+                                         v8::Local<v8::Function>());
+    return;
+  }
+  if (feature == "ServiceWorkerNavigationPreload") {
+    v8::Local<v8::Object> instanceObject = scriptState->context()->Global();
+    V8WindowPartial::installServiceWorkerNavigationPreload(
+        isolate, world, instanceObject, prototypeObject, interfaceObject);

[iclelland, 2017/01/26 20:14:11]

Can you replace prototypeObject and interfaceObject with explicitly empty
objects here? (like in ImageCapture and WebUSB) -- I don't think there's any
real issue here, but it *looks* a lot like passing uninitialized locals, and I'd
rather be clear that these aren't just reusing values from earlier in the
method, or being used uninitialized.

[chasej, 2017/01/27 17:22:36]

Done.

+    if (getExistingConstructorAndPrototypeForType(
+            &V8FetchEvent::wrapperTypeInfo, scriptState, &prototypeObject,
+            &interfaceObject)) {
+      V8FetchEvent::installServiceWorkerNavigationPreload(
+          isolate, world, v8::Local<v8::Object>(), prototypeObject,
+          interfaceObject);
+    }
+    if (getExistingConstructorAndPrototypeForType(
+            &V8ServiceWorkerRegistration::wrapperTypeInfo, scriptState,
+            &prototypeObject, &interfaceObject)) {
+      V8ServiceWorkerRegistration::installServiceWorkerNavigationPreload(
+          isolate, world, v8::Local<v8::Object>(), prototypeObject,
+          interfaceObject);
+    }
+    return;
+  }
+  if (feature == "WebShare") {
+    if (getExistingConstructorAndPrototypeForType(&V8Navigator::wrapperTypeInfo,
+                                                  scriptState, &prototypeObject,
+                                                  &interfaceObject)) {
+      V8NavigatorPartial::installWebShare(isolate, world,
+                                          v8::Local<v8::Object>(),
+                                          prototypeObject, interfaceObject);
+    }
+    return;
+  }
+  if (feature == "WebUSB") {
+    v8::Local<v8::Object> instanceObject = scriptState->context()->Global();
+    V8WindowPartial::installWebUSB(isolate, world, instanceObject,
+                                   v8::Local<v8::Object>(),
+                                   v8::Local<v8::Function>());
+    if (getExistingConstructorAndPrototypeForType(&V8Navigator::wrapperTypeInfo,
+                                                  scriptState, &prototypeObject,
+                                                  &interfaceObject)) {
+      V8NavigatorPartial::installWebUSB(isolate, world, v8::Local<v8::Object>(),
+                                        prototypeObject, interfaceObject);
+    }
+    return;
+  }
+  if (feature == "WebVR") {
+    v8::Local<v8::Object> instanceObject = scriptState->context()->Global();
+    V8WindowPartial::installGamepadExtensions(isolate, world, instanceObject,
+                                              prototypeObject, interfaceObject);

[iclelland, 2017/01/26 20:14:11]

ditto here and the next line.

[chasej, 2017/01/27 17:22:36]

Done.

+    V8WindowPartial::installWebVR(isolate, world, instanceObject,
+                                  prototypeObject, interfaceObject);
+    if (getExistingConstructorAndPrototypeForType(&V8Gamepad::wrapperTypeInfo,
+                                                  scriptState, &prototypeObject,
+                                                  &interfaceObject)) {
+      V8Gamepad::installGamepadExtensions(isolate, world,
+                                          v8::Local<v8::Object>(),
+                                          prototypeObject, interfaceObject);
+    }
+    if (getExistingConstructorAndPrototypeForType(
+            &V8GamepadButton::wrapperTypeInfo, scriptState, &prototypeObject,
+            &interfaceObject)) {
+      V8GamepadButton::installGamepadExtensions(
+          isolate, world, v8::Local<v8::Object>(), prototypeObject,
+          interfaceObject);
+    }
+    if (getExistingConstructorAndPrototypeForType(&V8Navigator::wrapperTypeInfo,
+                                                  scriptState, &prototypeObject,
+                                                  &interfaceObject)) {
+      V8NavigatorPartial::installWebVR(isolate, world, v8::Local<v8::Object>(),
+                                       prototypeObject, interfaceObject);
+    }
+    return;
+  }
+}
+
 void registerInstallConditionalFeaturesForModules() {
   s_originalInstallConditionalFeaturesFunction =
       setInstallConditionalFeaturesFunction(
           &installConditionalFeaturesForModules);
+  s_originalInstallPendingConditionalFeatureFunction =
+      setInstallPendingConditionalFeatureFunction(
+          &installPendingConditionalFeatureForModules);
 }
 
 }  // namespace blink