third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added.html - Issue 2640823004: Allow origin trials to be enabled by script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added.html

Issue 2640823004: Allow origin trials to be enabled by script (Closed)

Patch Set: Add tracking of installed features Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js ('k') | third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access.html » ('j') | third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>Test Sample API when trial is enabled by script-added meta tag</title>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script src="resources/origin_trials.js"></script>

	7 <script>

	8

	9 // TODO(iclelland): Generate this sample token during the build. The token

	10 // below will expire in 2033, but it would be better to always have a token wh ich

	11 // is guaranteed to be valid when the tests are run. -->

	12 // Generate this token with the command:

	13 // generate_token.py http://127.0.0.1:8000 Frobulate -expire-timestamp=200000000 0

	14 var token = "AlCoOPbezqtrGMzSzbLQC4c+oPqO6yuioemcBPjgcXajF8jtmZr4B8tJRPAARPbsX6h DeVyXCKHzEJfpBXvZgQEAAABReyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR 1cmUiOiAiRnJvYnVsYXRlIiwgImV4cGlyeSI6IDIwMDAwMDAwMDB9";

	15

	16 // The trial is not enabled, as no token is provided.

	17 // - Skip the worker tests, as they will likely fail due to running after the
	iclelland 2017/01/20 14:31:19 Can we chain these tests, so that the worker tests Can we chain these tests, so that the worker tests are allowed to run (and fail) before we continue by adding the token? chasej 2017/01/25 19:58:20 I looked into that, but wasn't able to find a simp Show quoted text On 2017/01/20 14:31:19, iclelland wrote: > Can we chain these tests, so that the worker tests are allowed to run (and fail) > before we continue by adding the token? I looked into that, but wasn't able to find a simple way to do so. I then figured that the disabled worker tests don't provide much value here. It would be testing that a trial was unexpectedly enabled in a worker, when it didn't inherit tokens from the containing document. I would think it's possible to wait on the worker tests, but it doesn't seem worth the additional effort. Is there a reason why this is important that I'm missing?
	18 // token is added below.

	19 var skip_worker = true;

	20 expect_failure(skip_worker);

	21

	22 // Add the token to enable the trial

	23 var tokenElement = document.createElement('meta');

	24 tokenElement.httpEquiv = "origin-trial";

	25 tokenElement.content = token;

	26 document.head.appendChild(tokenElement);

	27

	28 // The trial is now enabled, by the token added via script.

	29 expect_success();

	30

	31 </script>

OLD	NEW