Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 26408002: Fix build with system ICU when using bundled v8. (Closed)

Created:
7 years, 2 months ago by Paweł Hajdan Jr.
Modified:
7 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Fix build with system ICU when using bundled v8. BUG=none R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/linux/unbundle/icu.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 2 months ago (2013-10-08 00:20:57 UTC) #1
Lei Zhang
lgtm
7 years, 2 months ago (2013-10-08 00:29:29 UTC) #2
Paweł Hajdan Jr.
7 years, 2 months ago (2013-10-08 00:47:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r227408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698