Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2640793006: Don't create FileState(s) for SDK source in _ContentCacheWrapper. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't create FileState(s) for SDK source in _ContentCacheWrapper. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/917a137a0311b4073bbdb583e9462a1278954cd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-19 04:28:23 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-19 14:16:53 UTC) #2
scheglov
3 years, 11 months ago (2017-01-19 16:52:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
917a137a0311b4073bbdb583e9462a1278954cd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698