Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: src/crankshaft/x87/lithium-x87.cc

Issue 2640793004: Revert remove dead hole check logic (Closed)
Patch Set: Revert "[crankshaft] Fix mips/mips64 build: remove unused variable" and "[crankshaft] Remove dead Variable hole-checking code" Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x87/lithium-codegen-x87.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x87/lithium-x87.h" 5 #include "src/crankshaft/x87/lithium-x87.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X87 9 #if V8_TARGET_ARCH_X87
10 10
(...skipping 1963 matching lines...) Expand 10 before | Expand all | Expand 10 after
1974 return DefineAsRegister(new(zone()) LConstantT); 1974 return DefineAsRegister(new(zone()) LConstantT);
1975 } else { 1975 } else {
1976 UNREACHABLE(); 1976 UNREACHABLE();
1977 return NULL; 1977 return NULL;
1978 } 1978 }
1979 } 1979 }
1980 1980
1981 1981
1982 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 1982 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
1983 LOperand* context = UseRegisterAtStart(instr->value()); 1983 LOperand* context = UseRegisterAtStart(instr->value());
1984 return DefineAsRegister(new (zone()) LLoadContextSlot(context)); 1984 LInstruction* result =
1985 DefineAsRegister(new(zone()) LLoadContextSlot(context));
1986 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
1987 result = AssignEnvironment(result);
1988 }
1989 return result;
1985 } 1990 }
1986 1991
1987 1992
1988 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) { 1993 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
1989 LOperand* value; 1994 LOperand* value;
1990 LOperand* temp; 1995 LOperand* temp;
1991 LOperand* context = UseRegister(instr->context()); 1996 LOperand* context = UseRegister(instr->context());
1992 if (instr->NeedsWriteBarrier()) { 1997 if (instr->NeedsWriteBarrier()) {
1993 value = UseTempRegister(instr->value()); 1998 value = UseTempRegister(instr->value());
1994 temp = TempRegister(); 1999 temp = TempRegister();
1995 } else { 2000 } else {
1996 value = UseRegister(instr->value()); 2001 value = UseRegister(instr->value());
1997 temp = NULL; 2002 temp = NULL;
1998 } 2003 }
1999 return new (zone()) LStoreContextSlot(context, value, temp); 2004 LInstruction* result = new(zone()) LStoreContextSlot(context, value, temp);
2005 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
2006 result = AssignEnvironment(result);
2007 }
2008 return result;
2000 } 2009 }
2001 2010
2002 2011
2003 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { 2012 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
2004 LOperand* obj = (instr->access().IsExternalMemory() && 2013 LOperand* obj = (instr->access().IsExternalMemory() &&
2005 instr->access().offset() == 0) 2014 instr->access().offset() == 0)
2006 ? UseRegisterOrConstantAtStart(instr->object()) 2015 ? UseRegisterOrConstantAtStart(instr->object())
2007 : UseRegisterAtStart(instr->object()); 2016 : UseRegisterAtStart(instr->object());
2008 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); 2017 return DefineAsRegister(new(zone()) LLoadNamedField(obj));
2009 } 2018 }
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
2456 LOperand* index = UseTempRegister(instr->index()); 2465 LOperand* index = UseTempRegister(instr->index());
2457 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2466 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2458 LInstruction* result = DefineSameAsFirst(load); 2467 LInstruction* result = DefineSameAsFirst(load);
2459 return AssignPointerMap(result); 2468 return AssignPointerMap(result);
2460 } 2469 }
2461 2470
2462 } // namespace internal 2471 } // namespace internal
2463 } // namespace v8 2472 } // namespace v8
2464 2473
2465 #endif // V8_TARGET_ARCH_X87 2474 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/x87/lithium-codegen-x87.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698