Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: src/crankshaft/arm/lithium-arm.cc

Issue 2640793004: Revert remove dead hole check logic (Closed)
Patch Set: Revert "[crankshaft] Fix mips/mips64 build: remove unused variable" and "[crankshaft] Remove dead Variable hole-checking code" Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm/lithium-arm.h" 5 #include "src/crankshaft/arm/lithium-arm.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/arm/lithium-codegen-arm.h" 9 #include "src/crankshaft/arm/lithium-codegen-arm.h"
10 #include "src/crankshaft/hydrogen-osr.h" 10 #include "src/crankshaft/hydrogen-osr.h"
(...skipping 1957 matching lines...) Expand 10 before | Expand all | Expand 10 after
1968 return DefineAsRegister(new(zone()) LConstantT); 1968 return DefineAsRegister(new(zone()) LConstantT);
1969 } else { 1969 } else {
1970 UNREACHABLE(); 1970 UNREACHABLE();
1971 return NULL; 1971 return NULL;
1972 } 1972 }
1973 } 1973 }
1974 1974
1975 1975
1976 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 1976 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
1977 LOperand* context = UseRegisterAtStart(instr->value()); 1977 LOperand* context = UseRegisterAtStart(instr->value());
1978 return DefineAsRegister(new (zone()) LLoadContextSlot(context)); 1978 LInstruction* result =
1979 DefineAsRegister(new(zone()) LLoadContextSlot(context));
1980 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
1981 result = AssignEnvironment(result);
1982 }
1983 return result;
1979 } 1984 }
1980 1985
1981 1986
1982 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) { 1987 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
1983 LOperand* context; 1988 LOperand* context;
1984 LOperand* value; 1989 LOperand* value;
1985 if (instr->NeedsWriteBarrier()) { 1990 if (instr->NeedsWriteBarrier()) {
1986 context = UseTempRegister(instr->context()); 1991 context = UseTempRegister(instr->context());
1987 value = UseTempRegister(instr->value()); 1992 value = UseTempRegister(instr->value());
1988 } else { 1993 } else {
1989 context = UseRegister(instr->context()); 1994 context = UseRegister(instr->context());
1990 value = UseRegister(instr->value()); 1995 value = UseRegister(instr->value());
1991 } 1996 }
1992 return new (zone()) LStoreContextSlot(context, value); 1997 LInstruction* result = new(zone()) LStoreContextSlot(context, value);
1998 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
1999 result = AssignEnvironment(result);
2000 }
2001 return result;
1993 } 2002 }
1994 2003
1995 2004
1996 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { 2005 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
1997 LOperand* obj = UseRegisterAtStart(instr->object()); 2006 LOperand* obj = UseRegisterAtStart(instr->object());
1998 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); 2007 return DefineAsRegister(new(zone()) LLoadNamedField(obj));
1999 } 2008 }
2000 2009
2001 2010
2002 LInstruction* LChunkBuilder::DoLoadFunctionPrototype( 2011 LInstruction* LChunkBuilder::DoLoadFunctionPrototype(
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
2382 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2391 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2383 LOperand* object = UseRegister(instr->object()); 2392 LOperand* object = UseRegister(instr->object());
2384 LOperand* index = UseTempRegister(instr->index()); 2393 LOperand* index = UseTempRegister(instr->index());
2385 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2394 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2386 LInstruction* result = DefineSameAsFirst(load); 2395 LInstruction* result = DefineSameAsFirst(load);
2387 return AssignPointerMap(result); 2396 return AssignPointerMap(result);
2388 } 2397 }
2389 2398
2390 } // namespace internal 2399 } // namespace internal
2391 } // namespace v8 2400 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698