Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2640793003: Clear the FrameBuffer in case of backward jumps in the picture id. (Closed)

Created:
3 years, 11 months ago by philipel
Modified:
3 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clear the FrameBuffer in case of a backward jump in the picture id. Even though this is against the spec we allow a stream to continue if a backwards jump in the picture id occurs on a keyframe. BUG=webrtc:7001, webrtc:5514 Review-Url: https://codereview.webrtc.org/2640793003 Cr-Commit-Position: refs/heads/master@{#16146} Committed: https://chromium.googlesource.com/external/webrtc/+/fcc600651dfe50e2d6e27fc77e5acbf04f5a63cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -8 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 3 chunks +30 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
philipel
3 years, 11 months ago (2017-01-18 12:01:13 UTC) #3
stefan-webrtc
lgtm
3 years, 11 months ago (2017-01-18 12:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2640793003/1
3 years, 11 months ago (2017-01-18 12:25:32 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 13:35:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fcc600651dfe50e2d6e27fc77...

Powered by Google App Engine
This is Rietveld 408576698