Cleanups in remoting gn files.

remoting/remoting_enable.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
+import("//media/media_options.gni")
 
 declare_args() {
-  enable_remoting = !is_ios && !is_chromecast
+  enable_remoting = !is_ios && !is_chromecast && enable_webrtc
 }
-
-enable_remoting_host = false

[nicholss, 2017/01/20 23:05:22]

I am not sure it is better to move these to the remoting_options. These are
enable flags. Options to me mean more like feature or implementation flags.

[Sergey Ulanov, 2017/01/20 23:41:41]

Only the values declared in declare_args() can be overridden in gn args. These 2
were not in declare_args(). Note that remoting_options.gni also has
declare_args() section with some values there. Every other value that's not in
declare_args() is a function of these args and the build environment (such as
is_os flags).
The difference between remoting_options.gni and remoting_enable.gni files is
completely unclear, and I'm not sure we need both. For example, why
enable_remoting_host was in this file, while remoting_multi_process is in
remoting_options.gni? For now I kept enable_remoting in this file because it is
referenced outside of the remoting directory, but in the future I think we
should merged these 2 files. I don't see any reason to keep them separate. WDYT?

-enable_me2me_host = false
-
-if (is_win || (is_linux && !is_chromeos && use_x11) || is_mac) {
-  enable_remoting_host = true
-  enable_me2me_host = true
-}
-
-if (is_linux && is_chromeos) {
-  enable_remoting_host = true
-}