Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: components/autofill/core/common/form_field_data.h

Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier (Closed)
Patch Set: Fixed failed test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/form_field_data.h
diff --git a/components/autofill/core/common/form_field_data.h b/components/autofill/core/common/form_field_data.h
index dbcb3ea445e55fed9137b3bfd2f50161cf4e4bcb..a4de0a2236c10ac6aee78afe8352afd6db32ffd7 100644
--- a/components/autofill/core/common/form_field_data.h
+++ b/components/autofill/core/common/form_field_data.h
@@ -69,6 +69,7 @@ struct FormFieldData {
// serializing functions (in the .cc file) and the constructor.
base::string16 label;
base::string16 name;
+ base::string16 id;
base::string16 value;
std::string form_control_type;
std::string autocomplete_attribute;
@@ -118,6 +119,7 @@ std::ostream& operator<<(std::ostream& os, const FormFieldData& field);
EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \
EXPECT_EQ(expected.check_status, actual.check_status); \
EXPECT_EQ(expected.properties_mask, actual.properties_mask); \
+ EXPECT_EQ(expected.id, actual.id); \
} while (0)
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698