components/autofill/core/browser/form_structure.cc - Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier (Closed)

Patch Set: Fixed failed test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/form_structure.cc

diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc

index 278cc7b6de325d2c2b62fdb613850f92e9f0673d..ff24fce0b6e5f68de976103bc957e5ddf91a140f 100644

--- a/components/autofill/core/browser/form_structure.cc

+++ b/components/autofill/core/browser/form_structure.cc

@@ -1159,6 +1159,9 @@ void FormStructure::EncodeFormForUpload(AutofillUploadContents* upload) const {

if (!field->name.empty())

added_field->set_name(base::UTF16ToUTF8(field->name));

+ if (!field->id.empty())

+ added_field->set_id(base::UTF16ToUTF8(field->id));

if (!field->autocomplete_attribute.empty())

added_field->set_autocomplete(field->autocomplete_attribute);