Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc

Issue 2640763003: Optimize away updatable_queue_set_ (Closed)
Patch Set: Fix lock issue plus rename OnPushQueue Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
index 0f29b010623b4604bd00487cb0db55197fbd2e6c..de0b9c4124f5b436db80a12e9f211495b0c3abb4 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
@@ -35,7 +35,8 @@ class WorkQueueSetsTest : public testing::Test {
};
WorkQueue* NewTaskQueue(const char* queue_name) {
- WorkQueue* queue = new WorkQueue(nullptr, "test");
+ WorkQueue* queue =
+ new WorkQueue(nullptr, "test", WorkQueue::QueueType::IMMEDIATE);
work_queues_.push_back(base::WrapUnique(queue));
work_queue_sets_->AddQueue(queue, TaskQueue::CONTROL_PRIORITY);
return queue;
@@ -70,7 +71,7 @@ TEST_F(WorkQueueSetsTest, GetOldestQueueInSet_QueueEmpty) {
work_queue_sets_->GetOldestQueueInSet(set, &selected_work_queue));
}
-TEST_F(WorkQueueSetsTest, OnPushQueue) {
+TEST_F(WorkQueueSetsTest, OnTaskPushedToEmptyQueue) {
WorkQueue* work_queue = NewTaskQueue("queue");
size_t set = TaskQueue::NORMAL_PRIORITY;
work_queue_sets_->ChangeSetIndex(work_queue, set);
@@ -79,7 +80,7 @@ TEST_F(WorkQueueSetsTest, OnPushQueue) {
EXPECT_FALSE(
work_queue_sets_->GetOldestQueueInSet(set, &selected_work_queue));
- // Calls OnPushQueue.
+ // Calls OnTaskPushedToEmptyQueue.
work_queue->Push(FakeTaskWithEnqueueOrder(10));
EXPECT_TRUE(work_queue_sets_->GetOldestQueueInSet(set, &selected_work_queue));

Powered by Google App Engine
This is Rietveld 408576698