Optimize away updatable_queue_set_

third_party/WebKit/Source/platform/scheduler/base/work_queue.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/scheduler/base/work_queue.h"
 
 #include "platform/scheduler/base/work_queue_sets.h"
 
 namespace blink {
 namespace scheduler {
 namespace internal {
 
-WorkQueue::WorkQueue(TaskQueueImpl* task_queue, const char* name)
+WorkQueue::WorkQueue(TaskQueueImpl* task_queue,
+                     const char* name,
+                     QueueType queue_type)
     : work_queue_sets_(nullptr),
       task_queue_(task_queue),
       work_queue_set_index_(0),
       name_(name),
-      fence_(0) {}
+      fence_(0),
+      queue_type_(queue_type) {}
 
 void WorkQueue::AsValueInto(base::trace_event::TracedValue* state) const {
   for (const TaskQueueImpl::Task& task : work_queue_) {
     TaskQueueImpl::TaskAsValueInto(task, state);
   }
 }
 
 WorkQueue::~WorkQueue() {
   DCHECK(!work_queue_sets_) << task_queue_->GetName() << " : "
                             << work_queue_sets_->name() << " : " << name_;
@@ skipping 40 matching lines @@
 #endif
 
   // Amoritized O(1).
   work_queue_.push_back(std::move(task));
 
   if (!was_empty)
     return;
 
   // If we hit the fence, pretend to WorkQueueSets that we're empty.
   if (work_queue_sets_ && !BlockedByFence())
-    work_queue_sets_->OnPushQueue(this);
+    work_queue_sets_->OnTaskPushedToEmptyQueue(this);
 }
 
 void WorkQueue::PopTaskForTest() {
   if (work_queue_.empty())
     return;
   work_queue_.pop_front();
 }
 
-void WorkQueue::SwapLocked(WTF::Deque<TaskQueueImpl::Task>& incoming_queue) {
+void WorkQueue::ReloadEmptyImmediateQueue() {
   DCHECK(work_queue_.empty());
-  work_queue_.swap(incoming_queue);
+
+  work_queue_ = task_queue_->TakeImmediateIncomingQueue();
   if (work_queue_.empty())
     return;
+
   // If we hit the fence, pretend to WorkQueueSets that we're empty.
   if (work_queue_sets_ && !BlockedByFence())
-    work_queue_sets_->OnPushQueue(this);
+    work_queue_sets_->OnTaskPushedToEmptyQueue(this);
 }
 
 TaskQueueImpl::Task WorkQueue::TakeTaskFromWorkQueue() {
   DCHECK(work_queue_sets_);
   DCHECK(!work_queue_.empty());
 
   // Skip over canceled tasks, except for the last one since we always return
   // something.
   while (work_queue_.size() > 1u && work_queue_.front().task.IsCancelled()) {
     work_queue_.pop_front();
   }
 
   TaskQueueImpl::Task pending_task = work_queue_.takeFirst();
+  // NB immediate tasks have a different pipeline to delayed ones.
+  if (queue_type_ == QueueType::IMMEDIATE && work_queue_.empty()) {
+    // Short-circuit the queue reload so that OnPopQueue does the right thing.
+    work_queue_ = task_queue_->TakeImmediateIncomingQueue();
+  }
+  // OnPopQueue calls GetFrontTaskEnqueueOrder which checks BlockedByFence() so
+  // we don't need to here.
   work_queue_sets_->OnPopQueue(this);
   task_queue_->TraceQueueSize(false);
   return pending_task;
 }
 
 void WorkQueue::AssignToWorkQueueSets(WorkQueueSets* work_queue_sets) {
   work_queue_sets_ = work_queue_sets;
 }
 
 void WorkQueue::AssignSetIndex(size_t work_queue_set_index) {
   work_queue_set_index_ = work_queue_set_index;
 }
 
 bool WorkQueue::InsertFence(EnqueueOrder fence) {
   DCHECK_NE(fence, 0u);
   DCHECK(fence >= fence_ || fence == 1u);
   bool was_blocked_by_fence = BlockedByFence();
   fence_ = fence;
   // Moving the fence forward may unblock some tasks.
   if (work_queue_sets_ && !work_queue_.empty() && was_blocked_by_fence &&
       !BlockedByFence()) {
-    work_queue_sets_->OnPushQueue(this);
+    work_queue_sets_->OnTaskPushedToEmptyQueue(this);
     return true;
   }
   // Fence insertion may have blocked all tasks in this work queue.
   if (BlockedByFence())
     work_queue_sets_->OnQueueBlocked(this);
   return false;
 }
 
 bool WorkQueue::RemoveFence() {
   bool was_blocked_by_fence = BlockedByFence();
   fence_ = 0;
   if (work_queue_sets_ && !work_queue_.empty() && was_blocked_by_fence) {
-    work_queue_sets_->OnPushQueue(this);
+    work_queue_sets_->OnTaskPushedToEmptyQueue(this);
     return true;
   }
   return false;
 }
 
 bool WorkQueue::ShouldRunBefore(const WorkQueue* other_queue) const {
   DCHECK(!work_queue_.empty());
   DCHECK(!other_queue->work_queue_.empty());
   EnqueueOrder enqueue_order = 0;
   EnqueueOrder other_enqueue_order = 0;
   bool have_task = GetFrontTaskEnqueueOrder(&enqueue_order);
   bool have_other_task =
       other_queue->GetFrontTaskEnqueueOrder(&other_enqueue_order);
   DCHECK(have_task);
   DCHECK(have_other_task);
   return enqueue_order < other_enqueue_order;
 }
 
 }  // namespace internal
 }  // namespace scheduler
 }  // namespace blink