Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2640763003: Optimize away updatable_queue_set_ (Closed)
Patch Set: Fix lock issue plus rename OnPushQueue Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/base/time_domain.h" 5 #include "platform/scheduler/base/time_domain.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/test/simple_test_tick_clock.h" 9 #include "base/test/simple_test_tick_clock.h"
10 #include "cc/test/ordered_simple_task_runner.h" 10 #include "cc/test/ordered_simple_task_runner.h"
(...skipping 17 matching lines...) Expand all
28 : TimeDomain(observer), 28 : TimeDomain(observer),
29 now_(base::TimeTicks() + base::TimeDelta::FromSeconds(1)) {} 29 now_(base::TimeTicks() + base::TimeDelta::FromSeconds(1)) {}
30 30
31 ~MockTimeDomain() override {} 31 ~MockTimeDomain() override {}
32 32
33 using TimeDomain::NextScheduledRunTime; 33 using TimeDomain::NextScheduledRunTime;
34 using TimeDomain::NextScheduledTaskQueue; 34 using TimeDomain::NextScheduledTaskQueue;
35 using TimeDomain::ScheduleDelayedWork; 35 using TimeDomain::ScheduleDelayedWork;
36 using TimeDomain::UnregisterQueue; 36 using TimeDomain::UnregisterQueue;
37 using TimeDomain::UpdateWorkQueues; 37 using TimeDomain::UpdateWorkQueues;
38 using TimeDomain::RegisterAsUpdatableTaskQueue; 38 using TimeDomain::OnQueueHasIncomingImmediateWork;
39 39
40 // TimeSource implementation: 40 // TimeSource implementation:
41 LazyNow CreateLazyNow() const override { return LazyNow(now_); } 41 LazyNow CreateLazyNow() const override { return LazyNow(now_); }
42 base::TimeTicks Now() const override { return now_; } 42 base::TimeTicks Now() const override { return now_; }
43 43
44 void AsValueIntoInternal( 44 void AsValueIntoInternal(
45 base::trace_event::TracedValue* state) const override {} 45 base::trace_event::TracedValue* state) const override {}
46 46
47 bool MaybeAdvanceTime() override { return false; } 47 bool MaybeAdvanceTime() override { return false; }
48 const char* GetName() const override { return "Test"; } 48 const char* GetName() const override { return "Test"; }
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 MockTimeDomain* CreateMockTimeDomain() override { 228 MockTimeDomain* CreateMockTimeDomain() override {
229 observer_.reset(new MockObserver()); 229 observer_.reset(new MockObserver());
230 return new MockTimeDomain(observer_.get()); 230 return new MockTimeDomain(observer_.get());
231 } 231 }
232 232
233 std::unique_ptr<MockObserver> observer_; 233 std::unique_ptr<MockObserver> observer_;
234 }; 234 };
235 235
236 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) { 236 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) {
237 EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork(task_queue_.get())); 237 EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork(task_queue_.get()));
238 time_domain_->RegisterAsUpdatableTaskQueue(task_queue_.get()); 238 time_domain_->OnQueueHasIncomingImmediateWork(task_queue_.get());
239 } 239 }
240 240
241 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) { 241 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) {
242 EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork(task_queue_.get())); 242 EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork(task_queue_.get()));
243 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _)); 243 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _));
244 base::TimeTicks now = time_domain_->Now(); 244 base::TimeTicks now = time_domain_->Now();
245 time_domain_->ScheduleDelayedWork( 245 time_domain_->ScheduleDelayedWork(
246 task_queue_.get(), now + base::TimeDelta::FromMilliseconds(10), now); 246 task_queue_.get(), now + base::TimeDelta::FromMilliseconds(10), now);
247 } 247 }
248 248
249 } // namespace scheduler 249 } // namespace scheduler
250 } // namespace blink 250 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698