Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: src/heap/heap-inl.h

Issue 2640623002: [heap] VerifyPointersVisitor should check that non-HeapObjects are Smis (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index 4d060f8e431a7ec8164645f0a6cfd47a2fe56f25..11b587886e013f331d354254e484fdca2d28895a 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -850,6 +850,8 @@ void VerifyPointersVisitor::VisitPointers(Object** start, Object** end) {
HeapObject* object = HeapObject::cast(*current);
CHECK(object->GetIsolate()->heap()->Contains(object));
CHECK(object->map()->IsMap());
+ } else {
+ CHECK((*current)->IsSmi());
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698