runtime/vm/thread.h - Issue 2640573003: Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread.h

Issue 2640573003: Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid. (Closed)

Patch Set: Removed Dart API entry for IsValid. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread.h

diff --git a/runtime/vm/thread.h b/runtime/vm/thread.h

index 57a7c1f69405478a110f470e7af729d1d31e5dbc..76a72adaa6f7a2e6904edbc344d189ce90db277b 100644

--- a/runtime/vm/thread.h

+++ b/runtime/vm/thread.h

@@ -653,9 +653,12 @@ class Thread : public BaseThread {

// Visit all object pointers.

void VisitObjectPointers(ObjectPointerVisitor* visitor, bool validate_frames);

+ bool IsValidHandle(Dart_Handle object) const;

bool IsValidLocalHandle(Dart_Handle object) const;

intptr_t CountLocalHandles() const;

+ bool IsValidZoneHandle(Dart_Handle object) const;

intptr_t CountZoneHandles() const;

+ bool IsValidScopedHandle(Dart_Handle object) const;

intptr_t CountScopedHandles() const;

int ZoneSizeInBytes() const;

void UnwindScopes(uword stack_marker);