runtime/vm/unit_test.h - Issue 2640573003: Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unit_test.h

Issue 2640573003: Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid. (Closed)

Patch Set: Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/unit_test.h

diff --git a/runtime/vm/unit_test.h b/runtime/vm/unit_test.h

index c08f36efae6178098554acd010ee419041b60d5f..93f5dcafca6595d8e8eea19c23f36dc46534beca 100644

--- a/runtime/vm/unit_test.h

+++ b/runtime/vm/unit_test.h

@@ -11,6 +11,7 @@

#include "vm/ast.h"

#include "vm/dart.h"

+#include "vm/dart_api_state.h"

#include "vm/globals.h"

#include "vm/heap.h"

#include "vm/isolate.h"

@@ -539,6 +540,13 @@ class CompilerTest : public AllStatic {

#define EXPECT_VALID(handle) \

do { \

Dart_Handle tmp_handle = (handle); \

+ if (!Api::IsValid(tmp_handle)) { \

+ dart::Expect(__FILE__, __LINE__) \

+ .Fail( \

+ "expected '%s' to be a valid handle but '%s' has already been " \

+ "freed\n", \

+ #handle, #handle); \

+ } \

if (Dart_IsError(tmp_handle)) { \

dart::Expect(__FILE__, __LINE__) \

.Fail( \

« runtime/vm/handles_test.cc ('K') | « runtime/vm/thread_registry.cc ('k') | no next file » | no next file with comments »