Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid.

runtime/vm/thread.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread.h"
 
 #include "vm/compiler_stats.h"
 #include "vm/dart_api_state.h"
 #include "vm/growable_array.h"
 #include "vm/isolate.h"
@@ skipping 728 matching lines @@
     return Thread::name##_entry_point_offset();                                \
   }
   LEAF_RUNTIME_ENTRY_LIST(COMPUTE_OFFSET)
 #undef COMPUTE_OFFSET
 
   UNREACHABLE();
   return -1;
 }
 
 
+bool Thread::IsValidHandle(Dart_Handle object) const {
+  return IsValidLocalHandle(object) || IsValidZoneHandle(object) ||
+         IsValidScopedHandle(object);
+}
+
+
 bool Thread::IsValidLocalHandle(Dart_Handle object) const {
   ApiLocalScope* scope = api_top_scope_;
   while (scope != NULL) {
     if (scope->local_handles()->IsValidHandle(object)) {
       return true;
     }
     scope = scope->previous();
   }
   return false;
 }
 
 
 intptr_t Thread::CountLocalHandles() const {
   intptr_t total = 0;
   ApiLocalScope* scope = api_top_scope_;
   while (scope != NULL) {
     total += scope->local_handles()->CountHandles();
     scope = scope->previous();
   }
   return total;
 }
 
 
+bool Thread::IsValidZoneHandle(Dart_Handle object) const {
+  Zone* zone = zone_;
+  while (zone != NULL) {
+    if (zone->handles()->IsValidZoneHandle(reinterpret_cast<uword>(object))) {
+      return true;
+    }
+    zone = zone->previous();
+  }
+  return false;
+}
+
+
 intptr_t Thread::CountZoneHandles() const {
   intptr_t count = 0;
   Zone* zone = zone_;
   while (zone != NULL) {
     count += zone->handles()->CountZoneHandles();
     zone = zone->previous();
   }
   ASSERT(count >= 0);
   return count;
 }
 
 
+bool Thread::IsValidScopedHandle(Dart_Handle object) const {
+  Zone* zone = zone_;
+  while (zone != NULL) {
+    if (zone->handles()->IsValidScopedHandle(reinterpret_cast<uword>(object))) {
+      return true;
+    }
+    zone = zone->previous();
+  }
+  return false;
+}
+
+
 intptr_t Thread::CountScopedHandles() const {
   intptr_t count = 0;
   Zone* zone = zone_;
   while (zone != NULL) {
     count += zone->handles()->CountScopedHandles();
     zone = zone->previous();
   }
   ASSERT(count >= 0);
   return count;
 }
@@ skipping 50 matching lines @@
 
 DisableThreadInterruptsScope::~DisableThreadInterruptsScope() {
   if (thread() != NULL) {
     OSThread* os_thread = thread()->os_thread();
     ASSERT(os_thread != NULL);
     os_thread->EnableThreadInterrupts();
   }
 }
 
 }  // namespace dart