Resolution for issue #5092: Unit test handle checks consider dangling handles to be valid.

runtime/include/dart_api.h

 /*
  * Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
  * for details. All rights reserved. Use of this source code is governed by a
  * BSD-style license that can be found in the LICENSE file.
  */
 
 #ifndef RUNTIME_INCLUDE_DART_API_H_
 #define RUNTIME_INCLUDE_DART_API_H_
 
 /** \mainpage Dart Embedding API Reference
@@ skipping 241 matching lines @@
 typedef Dart_Handle Dart_PersistentHandle;
 typedef struct _Dart_WeakPersistentHandle* Dart_WeakPersistentHandle;
 
 typedef void (*Dart_WeakPersistentHandleFinalizer)(
     void* isolate_callback_data,
     Dart_WeakPersistentHandle handle,
     void* peer);
 typedef void (*Dart_PeerFinalizer)(void* peer);
 
 /**
+ * Is this handle valid, or has it been freed?
+ *
+ * Requires there to be a current isolate.
+ */
+DART_EXPORT bool Dart_IsValid(Dart_Handle handle);

[siva, 2017/01/18 23:27:06]

Why do we need this new API call, the issue you are addressing seems to only
talk about the EXPECT macros which are all internal to the VM

[bkonyi, 2017/01/19 01:05:13]

I was following the pattern of Dart_IsError so just assumed that there should be
a Dart_IsValid as well. I've removed it.

+
+/**
  * Is this an error handle?
  *
  * Requires there to be a current isolate.
  */
 DART_EXPORT bool Dart_IsError(Dart_Handle handle);
 
 /**
  * Is this an api error handle?
  *
  * Api error handles are produced when an api function is misused.
@@ skipping 3021 matching lines @@
  */
 DART_EXPORT bool Dart_IsPrecompiledRuntime();
 
 
 /**
  *  Print a native stack trace. Used for crash handling.
  */
 DART_EXPORT void Dart_DumpNativeStackTrace(void* context);
 
 #endif /* INCLUDE_DART_API_H_ */ /* NOLINT */