Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2640573002: Remove WebMediaPlayerDelegate null checks (Closed)
Patch Set: Fixed WMPMS and WMPA Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2874 matching lines...) Expand 10 before | Expand all | Expand 10 after
2885 media::RemotingRendererController* remoting_controller_ptr = 2885 media::RemotingRendererController* remoting_controller_ptr =
2886 remoting_controller.get(); 2886 remoting_controller.get();
2887 media_renderer_factory = base::MakeUnique<media::RemotingRendererFactory>( 2887 media_renderer_factory = base::MakeUnique<media::RemotingRendererFactory>(
2888 std::move(media_renderer_factory), std::move(remoting_controller)); 2888 std::move(media_renderer_factory), std::move(remoting_controller));
2889 #endif 2889 #endif
2890 2890
2891 if (!url_index_.get() || url_index_->frame() != frame_) 2891 if (!url_index_.get() || url_index_->frame() != frame_)
2892 url_index_.reset(new media::UrlIndex(frame_)); 2892 url_index_.reset(new media::UrlIndex(frame_));
2893 2893
2894 media::WebMediaPlayerImpl* media_player = new media::WebMediaPlayerImpl( 2894 media::WebMediaPlayerImpl* media_player = new media::WebMediaPlayerImpl(
2895 frame_, client, encrypted_client, 2895 frame_, client, encrypted_client, GetWebMediaPlayerDelegate(),
2896 GetWebMediaPlayerDelegate()->AsWeakPtr(),
2897 std::move(media_renderer_factory), url_index_, params); 2896 std::move(media_renderer_factory), url_index_, params);
2898 2897
2899 // TODO(http://crbug.com/673886): Re-enable overlays with VR shell enabled 2898 // TODO(http://crbug.com/673886): Re-enable overlays with VR shell enabled
2900 // when VR shell's video reprojection surface is enabled. Remove the setter 2899 // when VR shell's video reprojection surface is enabled. Remove the setter
2901 // and put the overlay feature check back in the constructor at that time. 2900 // and put the overlay feature check back in the constructor at that time.
2902 media_player->SetEnableFullscreenOverlays( 2901 media_player->SetEnableFullscreenOverlays(
2903 base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo) && 2902 base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo) &&
2904 !base::FeatureList::IsEnabled(features::kVrShell)); 2903 !base::FeatureList::IsEnabled(features::kVrShell));
2905 2904
2906 #if defined(OS_ANDROID) // WMPI_CAST 2905 #if defined(OS_ANDROID) // WMPI_CAST
(...skipping 3280 matching lines...) Expand 10 before | Expand all | Expand 10 after
6187 const WebSecurityOrigin& security_origin) { 6186 const WebSecurityOrigin& security_origin) {
6188 #if BUILDFLAG(ENABLE_WEBRTC) 6187 #if BUILDFLAG(ENABLE_WEBRTC)
6189 RenderThreadImpl* const render_thread = RenderThreadImpl::current(); 6188 RenderThreadImpl* const render_thread = RenderThreadImpl::current();
6190 6189
6191 scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner = 6190 scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner =
6192 render_thread->compositor_task_runner(); 6191 render_thread->compositor_task_runner();
6193 if (!compositor_task_runner.get()) 6192 if (!compositor_task_runner.get())
6194 compositor_task_runner = base::ThreadTaskRunnerHandle::Get(); 6193 compositor_task_runner = base::ThreadTaskRunnerHandle::Get();
6195 6194
6196 return new WebMediaPlayerMS( 6195 return new WebMediaPlayerMS(
6197 frame_, client, GetWebMediaPlayerDelegate()->AsWeakPtr(), 6196 frame_, client, GetWebMediaPlayerDelegate(),
6198 new RenderMediaLog(url::Origin(security_origin).GetURL()), 6197 new RenderMediaLog(url::Origin(security_origin).GetURL()),
6199 CreateRendererFactory(), render_thread->GetIOTaskRunner(), 6198 CreateRendererFactory(), render_thread->GetIOTaskRunner(),
6200 compositor_task_runner, render_thread->GetMediaThreadTaskRunner(), 6199 compositor_task_runner, render_thread->GetMediaThreadTaskRunner(),
6201 render_thread->GetWorkerTaskRunner(), render_thread->GetGpuFactories(), 6200 render_thread->GetWorkerTaskRunner(), render_thread->GetGpuFactories(),
6202 sink_id, security_origin); 6201 sink_id, security_origin);
6203 #else 6202 #else
6204 return NULL; 6203 return NULL;
6205 #endif // BUILDFLAG(ENABLE_WEBRTC) 6204 #endif // BUILDFLAG(ENABLE_WEBRTC)
6206 } 6205 }
6207 6206
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
6541 scoped_refptr<StreamTextureFactory> stream_texture_factory = 6540 scoped_refptr<StreamTextureFactory> stream_texture_factory =
6542 RenderThreadImpl::current()->GetStreamTexureFactory(); 6541 RenderThreadImpl::current()->GetStreamTexureFactory();
6543 if (!stream_texture_factory.get()) { 6542 if (!stream_texture_factory.get()) {
6544 LOG(ERROR) << "Failed to get stream texture factory!"; 6543 LOG(ERROR) << "Failed to get stream texture factory!";
6545 return NULL; 6544 return NULL;
6546 } 6545 }
6547 6546
6548 bool enable_texture_copy = 6547 bool enable_texture_copy =
6549 RenderThreadImpl::current()->EnableStreamTextureCopy(); 6548 RenderThreadImpl::current()->EnableStreamTextureCopy();
6550 return new WebMediaPlayerAndroid( 6549 return new WebMediaPlayerAndroid(
6551 frame_, client, encrypted_client, 6550 frame_, client, encrypted_client, GetWebMediaPlayerDelegate(),
6552 GetWebMediaPlayerDelegate()->AsWeakPtr(), GetMediaPlayerManager(), 6551 GetMediaPlayerManager(), stream_texture_factory, routing_id_,
6553 stream_texture_factory, routing_id_, enable_texture_copy, params); 6552 enable_texture_copy, params);
6554 } 6553 }
6555 6554
6556 RendererMediaPlayerManager* RenderFrameImpl::GetMediaPlayerManager() { 6555 RendererMediaPlayerManager* RenderFrameImpl::GetMediaPlayerManager() {
6557 if (!media_player_manager_) 6556 if (!media_player_manager_)
6558 media_player_manager_ = new RendererMediaPlayerManager(this); 6557 media_player_manager_ = new RendererMediaPlayerManager(this);
6559 return media_player_manager_; 6558 return media_player_manager_;
6560 } 6559 }
6561 #endif // defined(OS_ANDROID) 6560 #endif // defined(OS_ANDROID)
6562 6561
6563 media::MediaPermission* RenderFrameImpl::GetMediaPermission() { 6562 media::MediaPermission* RenderFrameImpl::GetMediaPermission() {
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
6874 // event target. Potentially a Pepper plugin will receive the event. 6873 // event target. Potentially a Pepper plugin will receive the event.
6875 // In order to tell whether a plugin gets the last mouse event and which it 6874 // In order to tell whether a plugin gets the last mouse event and which it
6876 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6875 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6877 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6876 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6878 // |pepper_last_mouse_event_target_|. 6877 // |pepper_last_mouse_event_target_|.
6879 pepper_last_mouse_event_target_ = nullptr; 6878 pepper_last_mouse_event_target_ = nullptr;
6880 #endif 6879 #endif
6881 } 6880 }
6882 6881
6883 } // namespace content 6882 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698