Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2640573002: Remove WebMediaPlayerDelegate null checks (Closed)
Patch Set: Undo accidental delete of WMPI::delegate_ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/media/webmediaplayer_ms_unittest.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2874 matching lines...) Expand 10 before | Expand all | Expand 10 after
2885 media::RemotingRendererController* remoting_controller_ptr = 2885 media::RemotingRendererController* remoting_controller_ptr =
2886 remoting_controller.get(); 2886 remoting_controller.get();
2887 media_renderer_factory = base::MakeUnique<media::RemotingRendererFactory>( 2887 media_renderer_factory = base::MakeUnique<media::RemotingRendererFactory>(
2888 std::move(media_renderer_factory), std::move(remoting_controller)); 2888 std::move(media_renderer_factory), std::move(remoting_controller));
2889 #endif 2889 #endif
2890 2890
2891 if (!url_index_.get() || url_index_->frame() != frame_) 2891 if (!url_index_.get() || url_index_->frame() != frame_)
2892 url_index_.reset(new media::UrlIndex(frame_)); 2892 url_index_.reset(new media::UrlIndex(frame_));
2893 2893
2894 media::WebMediaPlayerImpl* media_player = new media::WebMediaPlayerImpl( 2894 media::WebMediaPlayerImpl* media_player = new media::WebMediaPlayerImpl(
2895 frame_, client, encrypted_client, 2895 frame_, client, encrypted_client, GetWebMediaPlayerDelegate(),
2896 GetWebMediaPlayerDelegate()->AsWeakPtr(),
2897 std::move(media_renderer_factory), url_index_, params); 2896 std::move(media_renderer_factory), url_index_, params);
2898 2897
2899 #if defined(OS_ANDROID) // WMPI_CAST 2898 #if defined(OS_ANDROID) // WMPI_CAST
2900 media_player->SetMediaPlayerManager(GetMediaPlayerManager()); 2899 media_player->SetMediaPlayerManager(GetMediaPlayerManager());
2901 media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor()); 2900 media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());
2902 media_player->SetUseFallbackPath(use_fallback_path); 2901 media_player->SetUseFallbackPath(use_fallback_path);
2903 #endif // defined(OS_ANDROID) 2902 #endif // defined(OS_ANDROID)
2904 2903
2905 #if BUILDFLAG(ENABLE_MEDIA_REMOTING) 2904 #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
2906 remoting_controller_ptr->SetSwitchRendererCallback(base::Bind( 2905 remoting_controller_ptr->SetSwitchRendererCallback(base::Bind(
(...skipping 3272 matching lines...) Expand 10 before | Expand all | Expand 10 after
6179 const WebSecurityOrigin& security_origin) { 6178 const WebSecurityOrigin& security_origin) {
6180 #if BUILDFLAG(ENABLE_WEBRTC) 6179 #if BUILDFLAG(ENABLE_WEBRTC)
6181 RenderThreadImpl* const render_thread = RenderThreadImpl::current(); 6180 RenderThreadImpl* const render_thread = RenderThreadImpl::current();
6182 6181
6183 scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner = 6182 scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner =
6184 render_thread->compositor_task_runner(); 6183 render_thread->compositor_task_runner();
6185 if (!compositor_task_runner.get()) 6184 if (!compositor_task_runner.get())
6186 compositor_task_runner = base::ThreadTaskRunnerHandle::Get(); 6185 compositor_task_runner = base::ThreadTaskRunnerHandle::Get();
6187 6186
6188 return new WebMediaPlayerMS( 6187 return new WebMediaPlayerMS(
6189 frame_, client, GetWebMediaPlayerDelegate()->AsWeakPtr(), 6188 frame_, client, GetWebMediaPlayerDelegate(),
6190 new RenderMediaLog(url::Origin(security_origin).GetURL()), 6189 new RenderMediaLog(url::Origin(security_origin).GetURL()),
6191 CreateRendererFactory(), render_thread->GetIOTaskRunner(), 6190 CreateRendererFactory(), render_thread->GetIOTaskRunner(),
6192 compositor_task_runner, render_thread->GetMediaThreadTaskRunner(), 6191 compositor_task_runner, render_thread->GetMediaThreadTaskRunner(),
6193 render_thread->GetWorkerTaskRunner(), render_thread->GetGpuFactories(), 6192 render_thread->GetWorkerTaskRunner(), render_thread->GetGpuFactories(),
6194 sink_id, security_origin); 6193 sink_id, security_origin);
6195 #else 6194 #else
6196 return NULL; 6195 return NULL;
6197 #endif // BUILDFLAG(ENABLE_WEBRTC) 6196 #endif // BUILDFLAG(ENABLE_WEBRTC)
6198 } 6197 }
6199 6198
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
6533 scoped_refptr<StreamTextureFactory> stream_texture_factory = 6532 scoped_refptr<StreamTextureFactory> stream_texture_factory =
6534 RenderThreadImpl::current()->GetStreamTexureFactory(); 6533 RenderThreadImpl::current()->GetStreamTexureFactory();
6535 if (!stream_texture_factory.get()) { 6534 if (!stream_texture_factory.get()) {
6536 LOG(ERROR) << "Failed to get stream texture factory!"; 6535 LOG(ERROR) << "Failed to get stream texture factory!";
6537 return NULL; 6536 return NULL;
6538 } 6537 }
6539 6538
6540 bool enable_texture_copy = 6539 bool enable_texture_copy =
6541 RenderThreadImpl::current()->EnableStreamTextureCopy(); 6540 RenderThreadImpl::current()->EnableStreamTextureCopy();
6542 return new WebMediaPlayerAndroid( 6541 return new WebMediaPlayerAndroid(
6543 frame_, client, encrypted_client, 6542 frame_, client, encrypted_client, GetWebMediaPlayerDelegate(),
6544 GetWebMediaPlayerDelegate()->AsWeakPtr(), GetMediaPlayerManager(), 6543 GetMediaPlayerManager(), stream_texture_factory, routing_id_,
6545 stream_texture_factory, routing_id_, enable_texture_copy, params); 6544 enable_texture_copy, params);
6546 } 6545 }
6547 6546
6548 RendererMediaPlayerManager* RenderFrameImpl::GetMediaPlayerManager() { 6547 RendererMediaPlayerManager* RenderFrameImpl::GetMediaPlayerManager() {
6549 if (!media_player_manager_) 6548 if (!media_player_manager_)
6550 media_player_manager_ = new RendererMediaPlayerManager(this); 6549 media_player_manager_ = new RendererMediaPlayerManager(this);
6551 return media_player_manager_; 6550 return media_player_manager_;
6552 } 6551 }
6553 #endif // defined(OS_ANDROID) 6552 #endif // defined(OS_ANDROID)
6554 6553
6555 media::MediaPermission* RenderFrameImpl::GetMediaPermission() { 6554 media::MediaPermission* RenderFrameImpl::GetMediaPermission() {
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
6866 // event target. Potentially a Pepper plugin will receive the event. 6865 // event target. Potentially a Pepper plugin will receive the event.
6867 // In order to tell whether a plugin gets the last mouse event and which it 6866 // In order to tell whether a plugin gets the last mouse event and which it
6868 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6867 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6869 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6868 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6870 // |pepper_last_mouse_event_target_|. 6869 // |pepper_last_mouse_event_target_|.
6871 pepper_last_mouse_event_target_ = nullptr; 6870 pepper_last_mouse_event_target_ = nullptr;
6872 #endif 6871 #endif
6873 } 6872 }
6874 6873
6875 } // namespace content 6874 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/webmediaplayer_ms_unittest.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698