Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 264053007: [rAC] Display Autofill popups vertically compact. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review issue. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/personal_data_manager.cc
diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc
index d7ea312bc99a8293421bccf8be9dce660756c446..7fa4625c159b7d75077f203c8117d2645cdcc23a 100644
--- a/components/autofill/core/browser/personal_data_manager.cc
+++ b/components/autofill/core/browser/personal_data_manager.cc
@@ -24,6 +24,9 @@
#include "components/autofill/core/browser/phone_number_i18n.h"
#include "components/autofill/core/browser/validation.h"
#include "components/autofill/core/common/autofill_pref_names.h"
+#include "third_party/libaddressinput/chromium/cpp/src/region_data_constants.h"
+
+using ::i18n::addressinput::RegionDataConstants;
namespace autofill {
namespace {
@@ -566,7 +569,18 @@ void PersonalDataManager::GetProfileSuggestions(
std::vector<base::string16> multi_values;
profile->GetMultiInfo(type, app_locale_, &multi_values);
+ // Names need to be in vertically compact form - i.e. a single line. Join
+ // multi-line addresses into a single line, using a separator.
+ // The separator is locale-specific.
+ base::string16 compact_separator =
+ base::UTF8ToUTF16(RegionDataConstants::GetLanguageCompactLineSeparator(
+ profile->language_code()));
for (size_t i = 0; i < multi_values.size(); ++i) {
+ // Create vertically compact form.
+ base::ReplaceChars(multi_values[i],
+ base::ASCIIToUTF16("\n"),
+ compact_separator,
+ &multi_values[i]);
if (!field_is_autofilled) {
// Suggest data that starts with what the user has typed.
if (!multi_values[i].empty() &&
« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698