[rAC] Display Autofill popups vertically compact.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 68 matching lines @@
 #include "grit/component_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/libaddressinput_strings.h"
 #include "grit/platform_locale_settings.h"
 #include "grit/theme_resources.h"
 #include "net/cert/cert_status_flags.h"
 #include "third_party/libaddressinput/chromium/chrome_downloader_impl.h"
 #include "third_party/libaddressinput/chromium/chrome_storage_impl.h"
 #include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h"
 #include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h"
 #include "ui/base/base_window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/combobox_model.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image_skia_operations.h"
 #include "ui/gfx/skia_util.h"
 
 using ::i18n::addressinput::AddressData;
 using ::i18n::addressinput::AddressField;
@@ skipping 2035 matching lines @@
   // |popup_input_type_| must be set before calling |Show()|.
   popup_input_type_ = type;
 
   // TODO(estade): do we need separators and control rows like 'Clear
   // Form'?
   std::vector<int> popup_ids;
   for (size_t i = 0; i < popup_values.size(); ++i) {
     popup_ids.push_back(i);
   }
 
+  // Names need to be in vertically compact form - i.e. a single line. Join
+  // multi-line names into a single line, using a separator.
+  // The separator is locale-specific.
+  base::string16 compact_separator =
+      base::UTF8ToUTF16(::i18n::addressinput::GetCompactAddressLinesSeparator(
+          AddressLanguageCodeForSection(section)));
+  for (size_t i = 0; i < popup_values.size(); ++i) {
+    std::vector<base::string16> lines;
+    base::SplitString(popup_values[i], '\n', &lines);
+    popup_values[i] = (JoinString(lines, compact_separator));
+  }

[Evan Stade, 2014/05/07 00:46:16]

This needs to be done in GetProfileSuggestions so it applies to normal web
autofill as well.

This will be much easier after https://codereview.chromium.org/261013010/

+
   popup_controller_ = AutofillPopupControllerImpl::GetOrCreate(
       popup_controller_,
       weak_ptr_factory_.GetWeakPtr(),
       NULL,
       parent_view,
       content_bounds,
       base::i18n::IsRTL() ?
           base::i18n::RIGHT_TO_LEFT : base::i18n::LEFT_TO_RIGHT);
   popup_controller_->Show(popup_values,
                           popup_labels,
@@ skipping 1927 matching lines @@
   view_->UpdateButtonStrip();
 }
 
 void AutofillDialogControllerImpl::FetchWalletCookie() {
   net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
   signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
   signin_helper_->StartWalletCookieValueFetch();
 }
 
 }  // namespace autofill