Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 264053004: device/bluetooth: Improvements to GATT descriptor access API. (Closed)

Created:
6 years, 7 months ago by armansito
Modified:
6 years, 7 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Visibility:
Public.

Description

device/bluetooth: Improvements to GATT descriptor access API. This CL introduces the following changes to the GATT API: * New BluetoothGattService::Observer methods: - GattDescriptorAdded - GattDescriptorRemoved - GattDescriptorValueChanged * New BluetoothGattCharacteristic::GetDescriptor method to obtain a characteristic's descriptor by descriptor identifier. BUG=265663 TEST=device_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269138

Patch Set 1 #

Patch Set 2 : Pull & rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -1 line) Patch
M device/bluetooth/bluetooth_gatt_characteristic.h View 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 10 chunks +91 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 2 chunks +28 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 4 chunks +28 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 2 chunks +20 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_characteristic.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
armansito
6 years, 7 months ago (2014-05-05 23:28:36 UTC) #1
keybuk
lgtm
6 years, 7 months ago (2014-05-06 16:45:55 UTC) #2
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-07 19:00:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/264053004/20001
6 years, 7 months ago (2014-05-07 19:03:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 05:53:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 18:53:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13521)
6 years, 7 months ago (2014-05-08 18:53:19 UTC) #7
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-08 19:31:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/264053004/20001
6 years, 7 months ago (2014-05-08 19:34:17 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 01:42:27 UTC) #10
Message was sent while issue was closed.
Change committed as 269138

Powered by Google App Engine
This is Rietveld 408576698