Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: ios/showcase/common/protocol_alerter.mm

Issue 2640473002: Suggestions UI - favicon item (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/showcase/common/protocol_alerter.mm
diff --git a/ios/showcase/common/protocol_alerter.mm b/ios/showcase/common/protocol_alerter.mm
index 888f95788587f85c411caa070f86174428f47cf6..a1f4da85e3a4700894babf5c4eb96dbb99a7df5e 100644
--- a/ios/showcase/common/protocol_alerter.mm
+++ b/ios/showcase/common/protocol_alerter.mm
@@ -158,6 +158,8 @@ char kAssociatedProtocolNameKey;
switch (*type) {
case '@':
return [self objectDescriptionAtIndex:index];
+ case 'q':
+ return [self longLongDescriptionAtIndex:index];
// Add cases as needed here.
default:
return [NSString stringWithFormat:@"<Unknown Type:%c>", *type];
@@ -198,4 +200,13 @@ char kAssociatedProtocolNameKey;
range:range];
}
+// Returns a string describing an argument at |index| that is know to be a long
lpromero 2017/01/18 13:14:02 s/know/known
gambard 2017/01/18 14:19:09 Done.
+// long.
+- (NSString*)longLongDescriptionAtIndex:(NSInteger)index {
+ long long longLong;
lpromero 2017/01/18 13:14:02 s/longLong/value.
gambard 2017/01/18 14:19:09 Done.
+
+ [self getArgument:&longLong atIndex:index];
+ return [NSString stringWithFormat:@"%lld", longLong];
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698