Suggestions UI - favicon item

ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm

Index: ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm
diff --git a/ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm b/ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..3ea0a10732b5c15b98bff617ee6af2a56f62b3df
--- /dev/null
+++ b/ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm
@@ -0,0 +1,72 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/suggestions/suggestions_favicon_item.h"
+
+#include "base/mac/foundation_util.h"
+#import "ios/chrome/browser/ui/suggestions/suggestions_favicon_internal_cell.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#import "third_party/ocmock/OCMock/OCMock.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+namespace {
+
+SuggestionsFaviconInternalCell* GetInnerCell(
+    NSInteger cellIndex,
+    SuggestionsFaviconCell* outerCell) {
+  UICollectionViewCell* innerCell = [outerCell.collectionView.dataSource
+              collectionView:outerCell.collectionView
+      cellForItemAtIndexPath:[NSIndexPath indexPathForItem:cellIndex
+                                                 inSection:0]];
+
+  EXPECT_EQ([SuggestionsFaviconInternalCell class], [innerCell class]);
+  return base::mac::ObjCCastStrict<SuggestionsFaviconInternalCell>(innerCell);
+}
+
+#pragma mark - Tests
+
+// Tests that configureCell: set all the fields of the cell.
+TEST(SuggestionsFaviconItemTest, CellIsConfigured) {
+  id delegateMock =
+      [OCMockObject mockForProtocol:@protocol(SuggestionsFaviconCellDelegate)];
+  SuggestionsFaviconItem* item =
+      [[SuggestionsFaviconItem alloc] initWithType:0];
+  item.delegate = delegateMock;
+
+  SuggestionsFaviconCell* cell = [[[item cellClass] alloc] init];
+  ASSERT_TRUE([cell isMemberOfClass:[SuggestionsFaviconCell class]]);

[lpromero, 2017/01/18 09:34:39]

Optional: I almost commented on line 26 to use isMemberOfClass, but actually,
line 26 has an advantage when the classes don't match: the log tells you the
expected class and the actual class. Whereas here, you'll get:
Expected: YES, Actual: NO. Which doesn't quickly help.

[gambard, 2017/01/18 12:37:58]

Done.
This was the way it is done in most of the other "CellIsConfigured" tests.

[lpromero, 2017/01/18 13:14:02]

Sure, I only thought about it now :)

+
+  [item configureCell:cell];
+  EXPECT_EQ(delegateMock, cell.delegate);
+}
+
+// Tests that the favicon added to the item are correctly passed to the inner
+// collection view.
+TEST(SuggestionsFaviconItemTest, AddAFavicon) {
+  SuggestionsFaviconItem* item =
+      [[SuggestionsFaviconItem alloc] initWithType:0];
+  UIImage* image1 = [[UIImage alloc] init];
+  NSString* title1 = @"testTitle1";
+  UIImage* image2 = [[UIImage alloc] init];
+  NSString* title2 = @"testTitle2";
+  [item addFavicon:image1 withTitle:title1];
+  [item addFavicon:image2 withTitle:title2];
+
+  SuggestionsFaviconCell* cell = [[[item cellClass] alloc] init];
+
+  [item configureCell:cell];
+
+  SuggestionsFaviconInternalCell* faviconInternalCell1 = GetInnerCell(0, cell);
+  EXPECT_EQ(image1, faviconInternalCell1.faviconView.image);
+  EXPECT_TRUE([title1 isEqualToString:faviconInternalCell1.title.text]);
+
+  SuggestionsFaviconInternalCell* faviconInternalCell2 = GetInnerCell(1, cell);
+  EXPECT_EQ(image2, faviconInternalCell2.faviconView.image);
+  EXPECT_TRUE([title2 isEqualToString:faviconInternalCell2.title.text]);
+}
+
+}  // namespace