Suggestions UI - favicon item

ios/chrome/browser/ui/suggestions/suggestions_favicon_item.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_FAVICON_ITEM_H_
+#define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_FAVICON_ITEM_H_
+
+#import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
+#import "ios/third_party/material_components_ios/src/components/CollectionCells/src/MaterialCollectionCells.h"
+
+// Delegate for the SuggestionsFaviconCell, handling the interaction with the
+// inner collection view.
+@protocol SuggestionsFaviconCellDelegate
+
+// Opens the favicon associated with |indexPath|. Called when the inner cell of

[marq (ping after 24h), 2017/01/19 16:20:26]

So which collection is |indexPath| for, the overall collection view, or the
internal one inside the cell?

[gambard, 2017/01/19 17:37:32]

The one inside the cell. The second part of the comment should have make this
understandable.
I have updated it.

[lpromero, 2017/01/19 18:51:05]

Would something like the following be helpful?
- openFaviConAtInnerIndexPath:()innerIndexPath;

[gambard, 2017/01/20 07:38:49]

This is maybe too much. What about - openFaviconAtIndexPath:()innerIndexPath; ?

[lpromero, 2017/01/20 08:58:39]

lg

[gambard, 2017/01/20 12:25:57]

Done.

+// the SuggestionsFaviconCell at |indexPath| is selected.
+- (void)openFaviconAtIndexPath:(NSIndexPath*)indexPath;
+
+@end
+
+// Item for a cell containing favicons in the suggestions. The favicons are
+// presented in an inner collection view contained in the cell associated with
+// this item. The collection view scrolls horizontally.
+@interface SuggestionsFaviconItem : CollectionViewItem
+
+@property(nonatomic, weak) id<SuggestionsFaviconCellDelegate> delegate;
+
+// Adds a favicon with a |favicon| image and a |title| to this item.
+- (void)addFavicon:(UIImage*)favicon withTitle:(NSString*)title;
+
+@end
+
+// The corresponding cell of a favicon item.
+@interface SuggestionsFaviconCell : MDCCollectionViewCell
+
+// The inner collection view, used to display the favicons.
+@property(nonatomic, strong) UICollectionView* collectionView;
+
+@property(nonatomic, weak) id<SuggestionsFaviconCellDelegate> delegate;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_FAVICON_ITEM_H_