Suggestions UI - favicon item

ios/chrome/browser/ui/suggestions/suggestions_favicon_item.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_FAVICON_ITEM_H_
+#define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_FAVICON_ITEM_H_
+
+#import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
+#import "ios/third_party/material_components_ios/src/components/CollectionCells/src/MaterialCollectionCells.h"
+
+// Delegate for the SuggestionsFaviconCell, handling the interaction with the
+// inner collection view.
+@protocol SuggestionsFaviconCellDelegate
+
+// Opens the favicon associated with |indexPath|. Called when the inner cell of
+// the SuggestionsFaviconCell at |indexPath| is selected.
+- (void)openFaviconAtIndexPath:(NSIndexPath*)indexPath;

[lpromero, 2017/01/18 09:34:38]

No action needed: It might be fine here to pass an index path, as the cell
publicly exposes its collection view. 

[gambard, 2017/01/18 12:37:57]

Acknowledged.

+
+@end
+
+// Item for a cell containing favicons in the suggestions. The favicons are
+// presented in an inner collection view contained in the cell associated with
+// this item. The collection view scroll horizontally.

[lpromero, 2017/01/18 09:34:38]

scrolls

[gambard, 2017/01/18 12:37:58]

Done.

+@interface SuggestionsFaviconItem : CollectionViewItem
+
+@property(nonatomic, weak) id<SuggestionsFaviconCellDelegate> delegate;
+
+// Adds a favicon with an |favicon| image and a |title| to this item.

[lpromero, 2017/01/18 09:34:38]

s/an/a

[gambard, 2017/01/18 12:37:57]

Done.

+- (void)addFavicon:(UIImage*)favicon withTitle:(NSString*)title;

[lpromero, 2017/01/18 09:34:38]

Should you instead make the API accept an array? It would pair nicely with the
index you get back from the delegate. (You might need to create a dat holder
class that holds the title and favicon. It might just be what the mediator would
give to the view controller in input, right?)

[gambard, 2017/01/18 12:37:57]

My original intention was to pass an array of data holder. But as this API might
change when the mediator is created, I went for the simplest way to add a
favicon. I don't know if the favicons will all be created at the same time or
not, how they are added...
I will keep the API as is for now and see how I can optimize once I know which
information can be passed to it.

+
+@end
+
+// The corresponding cell of a favicon item.
+@interface SuggestionsFaviconCell : MDCCollectionViewCell
+
+// The inner collection view, used to display the favicons.
+@property(nonatomic, strong) UICollectionView* collectionView;
+
+@property(nonatomic, weak) id<SuggestionsFaviconCellDelegate> delegate;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_FAVICON_ITEM_H_