test/cctest/wasm/wasm-run-utils.h - Issue 2640453003: [wasm] Fix and tighten memory validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/wasm-run-utils.h

Issue 2640453003: [wasm] Fix and tighten memory validation (Closed)

Patch Set: Comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/wasm/wasm-run-utils.h

diff --git a/test/cctest/wasm/wasm-run-utils.h b/test/cctest/wasm/wasm-run-utils.h

index f85f4ca3e2ccec4cd5bdde5371e9128d69c366e6..64e801d8e267f375b96e6d3f6d92b89b448466ff 100644

--- a/test/cctest/wasm/wasm-run-utils.h

+++ b/test/cctest/wasm/wasm-run-utils.h

@@ -105,8 +105,10 @@ class TestingModule : public ModuleEnv {

void ChangeOriginToAsmjs() { module_.origin = kAsmJsOrigin; }

byte* AddMemory(uint32_t size) {

+ CHECK(!module_.has_memory);

CHECK_NULL(instance->mem_start);

CHECK_EQ(0, instance->mem_size);

+ module_.has_memory = true;

instance->mem_start = reinterpret_cast<byte*>(malloc(size));

CHECK(instance->mem_start);

memset(instance->mem_start, 0, size);