Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/wasm/wasm-run-utils.h

Issue 2640453003: [wasm] Fix and tighten memory validation (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/wasm/wasm-module.cc ('K') | « src/wasm/wasm-module.cc ('k') | test/mjsunit/regress/wasm/regression-667745.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/wasm-run-utils.h
diff --git a/test/cctest/wasm/wasm-run-utils.h b/test/cctest/wasm/wasm-run-utils.h
index f85f4ca3e2ccec4cd5bdde5371e9128d69c366e6..f1c70a7e1db37396cc7de2db4a6e18eb5f69600a 100644
--- a/test/cctest/wasm/wasm-run-utils.h
+++ b/test/cctest/wasm/wasm-run-utils.h
@@ -89,6 +89,7 @@ class TestingModule : public ModuleEnv {
instance->module = &module_;
instance->globals_start = global_data;
module_.globals_size = kMaxGlobalsSize;
+ module_.has_memory = true;
titzer 2017/01/18 10:17:30 Shouldn't you set this in AddMemory() below?
rossberg 2017/01/18 11:28:09 Done.
instance->mem_start = nullptr;
instance->mem_size = 0;
memset(global_data, 0, sizeof(global_data));
« src/wasm/wasm-module.cc ('K') | « src/wasm/wasm-module.cc ('k') | test/mjsunit/regress/wasm/regression-667745.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698