Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6766)

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

Issue 2640433004: ChromeOS MD: Fix cannot drag tab onto immersive fullscreen window (Closed)
Patch Set: comments from ps11 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
index 1a365347458817eec09cad8f63ece1f0821e364e..4735f87508e850b2daa888d704de4d562b559303 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
@@ -11,6 +11,7 @@
#include "ash/common/frame/default_header_painter.h"
#include "ash/common/frame/frame_border_hit_test.h"
#include "ash/common/frame/header_painter_util.h"
+#include "ash/common/material_design/material_design_controller.h"
#include "ash/common/wm_lookup.h"
#include "ash/common/wm_shell.h"
#include "ash/common/wm_window.h"
@@ -262,8 +263,15 @@ void BrowserNonClientFrameViewAsh::Layout() {
header_painter_->LayoutHeader();
int painted_height = GetTopInset(false);
- if (browser_view()->IsTabStripVisible())
- painted_height += browser_view()->tabstrip()->GetPreferredSize().height();
+ if (browser_view()->IsTabStripVisible()) {
+ const ImmersiveModeController* const immersive_controller =
+ browser_view()->immersive_mode_controller();
+ if (!immersive_controller->IsEnabled() ||
+ immersive_controller->IsRevealed() ||
+ !ash::MaterialDesignController::IsImmersiveModeMaterial()) {
+ painted_height += browser_view()->tabstrip()->GetPreferredSize().height();
+ }
+ }
header_painter_->SetHeaderHeightForPainting(painted_height);
@@ -384,6 +392,9 @@ int BrowserNonClientFrameViewAsh::GetTabStripRightInset() const {
}
bool BrowserNonClientFrameViewAsh::UseImmersiveLightbarHeaderStyle() const {
+ if (ash::MaterialDesignController::IsImmersiveModeMaterial())
+ return false;
+
const ImmersiveModeController* const immersive_controller =
browser_view()->immersive_mode_controller();
return immersive_controller->IsEnabled() &&
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698