Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 264043018: Support for png images served with "image/x-png" mime type (Closed)

Created:
6 years, 7 months ago by spartha
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support for png images served with "image/x-png" mime type The image/x-png is a non-standard mimetype, now replaced by image/png. Adding support to be backward compatible and also match the behavior of other browsers like Firefox. BUG=25293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M net/base/mime_util.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
spartha
The test case for the fix is available at https://codereview.chromium.org/270473002/
6 years, 7 months ago (2014-05-06 14:20:49 UTC) #1
abarth-chromium
lgtm
6 years, 7 months ago (2014-05-06 17:44:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/264043018/1
6 years, 7 months ago (2014-05-06 17:44:54 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 02:52:46 UTC) #4
spartha
The CQ bit was unchecked by sudarshan.p@samsung.com
6 years, 7 months ago (2014-05-07 04:19:53 UTC) #5
spartha
Need a owner lgtm!
6 years, 7 months ago (2014-05-07 04:55:27 UTC) #6
Ryan Sleevi
LGTM based on abarth.
6 years, 7 months ago (2014-05-07 18:55:53 UTC) #7
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 7 months ago (2014-05-08 07:32:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/264043018/1
6 years, 7 months ago (2014-05-08 07:34:53 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 23:51:07 UTC) #10
Message was sent while issue was closed.
Change committed as 269105

Powered by Google App Engine
This is Rietveld 408576698