Issue 264043012: Update tests/RecordOptsTest.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264043012: Update tests/RecordOptsTest.cpp (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
f(malita), mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Update tests/RecordOptsTest.cpp - use REPORTER_ASSERT; - assert the type first, then the pointer != NULL. This helps explain why ptr == NULL; - add a simpler NoopSaveRestore test case, which can help debugging failures of the larger test case. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14570

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	tests/RecordOptsTest.cpp	View		6 chunks	+32 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/264043012/1

6 years, 7 months ago (2014-05-05 16:59:42 UTC) #4

Message was sent while issue was closed.

Change committed as 14570

Expand Messages | Collapse Messages