Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 264043008: Reuse one UserPolicySigninService for Android and iOS. (Closed)

Created:
6 years, 7 months ago by Joao da Silva
Modified:
6 years, 7 months ago
Reviewers:
nyquist, dconnelly
CC:
chromium-reviews, binjin
Visibility:
Public.

Description

Reuse one UserPolicySigninService for Android and iOS. This change unifies the UserPolicySigninServices for Android and iOS into one class, to remove code duplication. The iOS version also gets support for recovering from offline signins: the policy registration will be performed on the next restart in that case, and checked again every 24 hours. BUG=273055, 344403, 278027 TBR=nyquist@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268178

Patch Set 1 #

Patch Set 2 : fix android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -527 lines) Patch
M chrome/browser/android/signin/signin_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/policy/cloud/user_policy_signin_service_android.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/policy/cloud/user_policy_signin_service_android.cc View 1 chunk +0 lines, -171 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_factory.cc View 2 chunks +3 lines, -5 lines 0 comments Download
D chrome/browser/policy/cloud/user_policy_signin_service_ios.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/policy/cloud/user_policy_signin_service_ios.mm View 1 chunk +0 lines, -140 lines 0 comments Download
A + chrome/browser/policy/cloud/user_policy_signin_service_mobile.h View 1 5 chunks +31 lines, -5 lines 0 comments Download
A + chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc View 1 5 chunks +62 lines, -10 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Joao da Silva
Daniel, PTAL. This is an upstreaming of https://chromereviews.googleplex.com/40847013. Bin, FYI. Feel free to start working ...
6 years, 7 months ago (2014-05-05 10:12:42 UTC) #1
Joao da Silva
This change is the same as from downstream, but it needed some fixes to build ...
6 years, 7 months ago (2014-05-05 11:32:35 UTC) #2
dconnelly
lgtm
6 years, 7 months ago (2014-05-05 11:40:19 UTC) #3
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 7 months ago (2014-05-05 12:57:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/264043008/20001
6 years, 7 months ago (2014-05-05 12:57:59 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-05 14:38:38 UTC) #6
Joao da Silva
+Tommy to TBR for the header update to signin_manager_android.cc
6 years, 7 months ago (2014-05-05 14:40:55 UTC) #7
commit-bot: I haz the power
Change committed as 268178
6 years, 7 months ago (2014-05-05 14:47:07 UTC) #8
nyquist
6 years, 7 months ago (2014-05-06 05:39:34 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698