VM: [Kernel] Ensure we don't capture :stack_trace variable in yielding functions

VM: [Kernel] Ensure we don't capture :stack_trace variable in yielding functions

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c5c7f45be0811a5fe0bca730fdd0b05ed68af619

[kustermann, 2017-01-19 17:51:55]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2017-01-19 17:52:50]

lgtm

[kustermann, 2017-01-19 17:53:30]

Description was changed from

==========
VM: [Kernel] Ensure we don't capture :stack_trace variable in yielding functions
==========

to

==========
VM: [Kernel] Ensure we don't capture :stack_trace variable in yielding functions

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5c7f45be0811a5fe0bca730fdd0b05ed68af619
==========

[kustermann, 2017-01-19 17:53:31]

Committed patchset #1 (id:1) manually as
c5c7f45be0811a5fe0bca730fdd0b05ed68af619 (presubmit successful).

[Florian Schneider, 2017-01-19 17:57:15]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-01-19 17:57:16]

dbc:

https://codereview.chromium.org/2640353002/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2640353002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:678: scope->VariableAt(offset +
i)->set_is_forced_stack();
Can we get rid of is_forced_stack?

(see the discussion a while ago about exception_var and stacktrace_var in the
kernel merge CL)

[kustermann, 2017-01-19 18:03:22]

On 2017/01/19 17:57:16, Florian Schneider wrote:
> dbc:
> 
> https://codereview.chromium.org/2640353002/diff/1/runtime/vm/kernel_to_il.cc
> File runtime/vm/kernel_to_il.cc (right):
> 
>
https://codereview.chromium.org/2640353002/diff/1/runtime/vm/kernel_to_il.cc#...
> runtime/vm/kernel_to_il.cc:678: scope->VariableAt(offset +
> i)->set_is_forced_stack();
> Can we get rid of is_forced_stack?
> 
> (see the discussion a while ago about exception_var and stacktrace_var in the
> kernel merge CL)

The plan was always to get rid of dart::kernel::ScopeBuilder which should allow
us to get rid of it.

Last thing I heard was that with @kmillikin's streaming flow graph builder
(which is in the works) the capturing information will be pre-computed in the
frontend.