Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: test/cctest/interpreter/bytecode_expectations/Modules.golden

Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/Modules.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Modules.golden b/test/cctest/interpreter/bytecode_expectations/Modules.golden
index db5b72c6ee84b5772176e4c73c913a9e39b43ea7..c6d6a24cdf7c2540748f88581d6425eab04d3ab4 100644
--- a/test/cctest/interpreter/bytecode_expectations/Modules.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Modules.golden
@@ -24,10 +24,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(63),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -50,7 +50,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 13 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -59,7 +59,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -96,10 +96,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(63),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -122,7 +122,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 24 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -131,7 +131,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -170,10 +170,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(63),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(4),
B(CallRuntime), U16(Runtime::kAbort), R(4), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(LdaConstant), U8(0),
B(Star), R(6),
@@ -196,7 +196,7 @@ bytecodes: [
B(SuspendGenerator), R(5),
B(Ldar), R(4),
/* 64 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(5), U8(1),
B(Star), R(6),
@@ -205,7 +205,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -218,13 +218,13 @@ bytecodes: [
/* 0 E> */ B(Throw),
/* 32 S> */ B(LdaUndefined),
B(Star), R(5),
- /* 32 E> */ B(LdaModuleVariable), U8(-1), U8(0),
+ /* 32 E> */ B(LdaModuleVariable), I8(-1), U8(0),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(1),
B(Star), R(6),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(6), U8(1),
B(Star), R(4),
- B(LdaSmi), U8(42),
+ B(LdaSmi), I8(42),
B(Star), R(6),
/* 32 E> */ B(Call), R(4), R(5), U8(2), U8(2),
B(Ldar), R(closure),
@@ -236,13 +236,13 @@ bytecodes: [
/* 47 E> */ B(StaCurrentContextSlot), U8(4),
/* 52 S> */ B(LdaUndefined),
B(Star), R(5),
- /* 52 E> */ B(LdaModuleVariable), U8(-1), U8(1),
+ /* 52 E> */ B(LdaModuleVariable), I8(-1), U8(1),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(1),
B(Star), R(6),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(6), U8(1),
B(Star), R(4),
- B(LdaSmi), U8(42),
+ B(LdaSmi), I8(42),
B(Star), R(6),
/* 52 E> */ B(Call), R(4), R(5), U8(2), U8(4),
B(PopContext), R(1),
@@ -276,10 +276,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(63),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(4),
B(CallRuntime), U16(Runtime::kAbort), R(4), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(LdaConstant), U8(0),
B(Star), R(6),
@@ -302,7 +302,7 @@ bytecodes: [
B(SuspendGenerator), R(5),
B(Ldar), R(4),
/* 49 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(5), U8(1),
B(Star), R(6),
@@ -311,7 +311,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -322,11 +322,11 @@ bytecodes: [
/* 49 S> */ B(Return),
B(Ldar), R(6),
/* 0 E> */ B(Throw),
- /* 17 S> */ B(LdaSmi), U8(42),
- /* 17 E> */ B(StaModuleVariable), U8(1), U8(0),
- /* 21 S> */ B(LdaModuleVariable), U8(1), U8(0),
+ /* 17 S> */ B(LdaSmi), I8(42),
+ /* 17 E> */ B(StaModuleVariable), I8(1), U8(0),
+ /* 21 S> */ B(LdaModuleVariable), I8(1), U8(0),
B(Inc), U8(2),
- /* 24 E> */ B(StaModuleVariable), U8(1), U8(0),
+ /* 24 E> */ B(StaModuleVariable), I8(1), U8(0),
B(Ldar), R(closure),
B(CreateBlockContext), U8(1),
B(PushContext), R(1),
@@ -334,9 +334,9 @@ bytecodes: [
B(StaCurrentContextSlot), U8(4),
/* 34 S> */ B(LdaUndefined),
/* 34 E> */ B(StaCurrentContextSlot), U8(4),
- /* 39 S> */ B(LdaModuleVariable), U8(1), U8(1),
+ /* 39 S> */ B(LdaModuleVariable), I8(1), U8(1),
B(Inc), U8(3),
- /* 42 E> */ B(StaModuleVariable), U8(1), U8(1),
+ /* 42 E> */ B(StaModuleVariable), I8(1), U8(1),
B(PopContext), R(1),
B(LdaUndefined),
/* 49 S> */ B(Return),
@@ -367,10 +367,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(67),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(4),
B(CallRuntime), U16(Runtime::kAbort), R(4), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(LdaConstant), U8(0),
B(Star), R(6),
@@ -381,7 +381,7 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
B(LdaTheHole),
- B(StaModuleVariable), U8(1), U8(0),
+ B(StaModuleVariable), I8(1), U8(0),
/* 0 E> */ B(StackCheck),
B(LdaCurrentContextSlot), U8(4),
B(Star), R(5),
@@ -395,7 +395,7 @@ bytecodes: [
B(SuspendGenerator), R(5),
B(Ldar), R(4),
/* 49 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(5), U8(1),
B(Star), R(6),
@@ -404,7 +404,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -415,11 +415,11 @@ bytecodes: [
/* 49 S> */ B(Return),
B(Ldar), R(6),
/* 0 E> */ B(Throw),
- /* 17 S> */ B(LdaSmi), U8(42),
- /* 17 E> */ B(StaModuleVariable), U8(1), U8(0),
- /* 21 S> */ B(LdaModuleVariable), U8(1), U8(0),
+ /* 17 S> */ B(LdaSmi), I8(42),
+ /* 17 E> */ B(StaModuleVariable), I8(1), U8(0),
+ /* 21 S> */ B(LdaModuleVariable), I8(1), U8(0),
B(Inc), U8(2),
- /* 24 E> */ B(StaModuleVariable), U8(1), U8(0),
+ /* 24 E> */ B(StaModuleVariable), I8(1), U8(0),
B(Ldar), R(closure),
B(CreateBlockContext), U8(1),
B(PushContext), R(1),
@@ -427,9 +427,9 @@ bytecodes: [
B(StaCurrentContextSlot), U8(4),
/* 34 S> */ B(LdaUndefined),
/* 34 E> */ B(StaCurrentContextSlot), U8(4),
- /* 39 S> */ B(LdaModuleVariable), U8(1), U8(1),
+ /* 39 S> */ B(LdaModuleVariable), I8(1), U8(1),
B(Inc), U8(3),
- /* 42 E> */ B(StaModuleVariable), U8(1), U8(1),
+ /* 42 E> */ B(StaModuleVariable), I8(1), U8(1),
B(PopContext), R(1),
B(LdaUndefined),
/* 49 S> */ B(Return),
@@ -460,10 +460,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(67),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(4),
B(CallRuntime), U16(Runtime::kAbort), R(4), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(LdaConstant), U8(0),
B(Star), R(6),
@@ -474,7 +474,7 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
B(LdaTheHole),
- B(StaModuleVariable), U8(1), U8(0),
+ B(StaModuleVariable), I8(1), U8(0),
/* 0 E> */ B(StackCheck),
B(LdaCurrentContextSlot), U8(4),
B(Star), R(5),
@@ -488,7 +488,7 @@ bytecodes: [
B(SuspendGenerator), R(5),
B(Ldar), R(4),
/* 51 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(2),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(5), U8(1),
B(Star), R(6),
@@ -497,7 +497,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(7), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -508,9 +508,9 @@ bytecodes: [
/* 51 S> */ B(Return),
B(Ldar), R(6),
/* 0 E> */ B(Throw),
- /* 19 S> */ B(LdaSmi), U8(42),
- /* 19 E> */ B(StaModuleVariable), U8(1), U8(0),
- /* 23 S> */ B(LdaModuleVariable), U8(1), U8(0),
+ /* 19 S> */ B(LdaSmi), I8(42),
+ /* 19 E> */ B(StaModuleVariable), I8(1), U8(0),
+ /* 23 S> */ B(LdaModuleVariable), I8(1), U8(0),
B(Inc), U8(2),
/* 26 E> */ B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
B(Ldar), R(closure),
@@ -520,7 +520,7 @@ bytecodes: [
B(StaCurrentContextSlot), U8(4),
/* 36 S> */ B(LdaUndefined),
/* 36 E> */ B(StaCurrentContextSlot), U8(4),
- /* 41 S> */ B(LdaModuleVariable), U8(1), U8(1),
+ /* 41 S> */ B(LdaModuleVariable), I8(1), U8(1),
B(Inc), U8(3),
/* 44 E> */ B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
B(PopContext), R(1),
@@ -551,10 +551,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(67),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -565,7 +565,7 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
B(LdaTheHole),
- B(StaModuleVariable), U8(1), U8(0),
+ B(StaModuleVariable), I8(1), U8(0),
/* 0 E> */ B(StackCheck),
B(LdaCurrentContextSlot), U8(4),
B(Star), R(4),
@@ -579,7 +579,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 32 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -588,7 +588,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -600,7 +600,7 @@ bytecodes: [
B(Ldar), R(5),
/* 0 E> */ B(Throw),
B(CreateClosure), U8(1), U8(2), U8(0),
- B(StaModuleVariable), U8(1), U8(0),
+ B(StaModuleVariable), I8(1), U8(0),
B(LdaUndefined),
/* 32 S> */ B(Return),
]
@@ -628,10 +628,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(67),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -642,7 +642,7 @@ bytecodes: [
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
B(LdaTheHole),
- B(StaModuleVariable), U8(1), U8(0),
+ B(StaModuleVariable), I8(1), U8(0),
/* 0 E> */ B(StackCheck),
B(LdaCurrentContextSlot), U8(4),
B(Star), R(4),
@@ -656,7 +656,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 26 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -665,7 +665,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -680,9 +680,9 @@ bytecodes: [
B(Star), R(3),
B(LdaTheHole),
B(Star), R(4),
- B(LdaSmi), U8(16),
+ B(LdaSmi), I8(16),
B(Star), R(6),
- B(LdaSmi), U8(24),
+ B(LdaSmi), I8(24),
B(Star), R(7),
B(Mov), R(3), R(5),
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(4),
@@ -691,7 +691,7 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kToFastProperties), R(3), U8(1),
B(StaCurrentContextSlot), U8(6),
B(LdaCurrentContextSlot), U8(6),
- /* 16 E> */ B(StaModuleVariable), U8(1), U8(0),
+ /* 16 E> */ B(StaModuleVariable), I8(1), U8(0),
B(LdaUndefined),
/* 26 S> */ B(Return),
]
@@ -719,10 +719,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(63),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -745,7 +745,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 30 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -754,7 +754,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -791,10 +791,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(63),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -817,7 +817,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 19 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -826,7 +826,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),
@@ -864,10 +864,10 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(73),
- B(LdaSmi), U8(78),
+ B(LdaSmi), I8(78),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(LdaConstant), U8(0),
B(Star), R(5),
@@ -894,7 +894,7 @@ bytecodes: [
B(SuspendGenerator), R(4),
B(Ldar), R(3),
/* 45 S> */ B(Return),
- B(LdaSmi), U8(-2),
+ B(LdaSmi), I8(-2),
B(Star), R(1),
B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(4), U8(1),
B(Star), R(5),
@@ -903,7 +903,7 @@ bytecodes: [
B(LdaZero),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(25),
- B(LdaSmi), U8(2),
+ B(LdaSmi), I8(2),
B(TestEqualStrict), R(6), U8(0),
B(JumpIfTrue), U8(15),
B(Jump), U8(2),

Powered by Google App Engine
This is Rietveld 408576698